Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2549063002: [DO NOT COMMIT] WebKit: remove DCHECK_IS_ON from FileWriterSync. (Closed)

Created:
4 years ago by nhiroki
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, blink-reviews, haraken, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DO NOT COMMIT] WebKit: remove DCHECK_IS_ON from FileWriterSync. This CL removes checks for DCHECK_IS_ON in FileWriterSync as they are not used. (DCHECK macro requires its arguments to be buildable even if check itself is disabled.) So this CL fixes build in case we want debug build with DCHECKs disabled. BUG=666660 patch from issue 2524813003 at patchset 40001 (http://crrev.com/2524813003#ps40001)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -25 lines) Patch
M third_party/WebKit/Source/modules/filesystem/FileWriterSync.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp View 4 chunks +6 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (5 generated)
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
4 years ago (2016-12-05 09:30:03 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549063002/1
4 years ago (2016-12-05 09:30:15 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-05 11:27:03 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years ago (2016-12-05 11:27:04 UTC) #4
nhiroki
4 years ago (2016-12-06 03:13:20 UTC) #5 
Description was changed from

==========
[DO NOT COMMIT] WebKit: remove DCHECK_IS_ON from FileWriterSync.

This CL removes checks for DCHECK_IS_ON in FileWriterSync as they are not used.
(DCHECK macro requires its arguments to be buildable even if check itself is
disabled.) So this CL fixes build in case we want debug build with DCHECKs
disabled.

BUG=666660

patch from issue 2524813003 at patchset 40001
(http://crrev.com/2524813003#ps40001)
==========

to

==========
[DO NOT COMMIT] WebKit: remove DCHECK_IS_ON from FileWriterSync.

This CL removes checks for DCHECK_IS_ON in FileWriterSync as they are not used.
(DCHECK macro requires its arguments to be buildable even if check itself is
disabled.) So this CL fixes build in case we want debug build with DCHECKs
disabled.

BUG=666660

patch from issue 2524813003 at patchset 40001
(http://crrev.com/2524813003#ps40001)
==========

Powered by Google App Engine
This is Rietveld 408576698