Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2549053002: Revert "[heap] Use RAIL mode for initial heap sizing" (Closed)

Created:
4 years ago by ulan
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[heap] Use RAIL mode for initial heap sizing" This reverts commit aea4f1a704829fcb3fc3584b9d9948deeb5bcaa5. Reason: performance regression on benchmarks (crbug.com/671118). BUG=chromium:671118, chromium:613518 TBR=hpayer@chromium.org Committed: https://crrev.com/a1680631ff09a6082538fd8887bab00e0bdb3383 Cr-Commit-Position: refs/heads/master@{#41479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -74 lines) Patch
M src/heap/heap.h View 5 chunks +10 lines, -11 lines 0 comments Download
M src/heap/heap.cc View 12 chunks +27 lines, -28 lines 0 comments Download
M src/heap/incremental-marking-job.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/heap/incremental-marking-job.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/isolate.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/isolate.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
ulan
ptal
4 years ago (2016-12-05 09:15:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549053002/1
4 years ago (2016-12-05 09:47:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 10:15:07 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-05 10:15:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1680631ff09a6082538fd8887bab00e0bdb3383
Cr-Commit-Position: refs/heads/master@{#41479}

Powered by Google App Engine
This is Rietveld 408576698