Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2549043002: chromeos: Cleanup class/struct fwd declarations (Closed)

Created:
4 years ago by jbriance
Modified:
4 years ago
Reviewers:
stevenjb
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Cleanup class/struct fwd declarations Remove useless class and struct forward declarations, and add missing ones in chromeos header files. BUG=662195 Committed: https://crrev.com/809c7c91f453b4db56431c7097142224c0a669b8 Cr-Commit-Position: refs/heads/master@{#436338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -44 lines) Patch
M chromeos/audio/audio_devices_pref_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/audio/audio_pref_observer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/audio/cras_audio_handler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/dbus/cros_disks_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/dbus_clients_browser.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/dbus_thread_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_cras_audio_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/dbus/mock_permission_broker_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/dbus/services/liveness_service_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/shill_client_helper.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/dbus/shill_device_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/shill_manager_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/dbus/shill_profile_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/login/auth/login_performer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/network/network_configuration_observer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/network/network_profile_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/proxy/proxy_config_handler.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jbriance
4 years ago (2016-12-05 08:57:03 UTC) #2
stevenjb
lgtm
4 years ago (2016-12-05 16:39:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549043002/1
4 years ago (2016-12-05 17:24:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 17:45:26 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-05 17:48:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/809c7c91f453b4db56431c7097142224c0a669b8
Cr-Commit-Position: refs/heads/master@{#436338}

Powered by Google App Engine
This is Rietveld 408576698