Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 254903002: When running locally on CrOS, don't create separate remote forwarder port (Closed)

Created:
6 years, 8 months ago by tbarzic
Modified:
6 years, 7 months ago
Reviewers:
achuithb
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

When running locally on CrOS, don't create separate remote forwarder port The wpr server will use DoNothingForwarder, which asserts that the remote port is the same as the local one, and the ports used are the ones in the CrOSBrowserBackend's wpr_port_pairs; so if running locally, use the local port as a remote one. BUG=359293 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270332

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tbarzic
this fixes 'Local port forwarding is not supported' assert I kept getting when running benchmarks ...
6 years, 8 months ago (2014-04-26 01:17:03 UTC) #1
tbarzic
On 2014/04/26 01:17:03, tbarzic wrote: > this fixes 'Local port forwarding is not supported' assert ...
6 years, 7 months ago (2014-05-05 20:28:13 UTC) #2
achuithb
On 2014/05/05 20:28:13, tbarzic wrote: > On 2014/04/26 01:17:03, tbarzic wrote: > > this fixes ...
6 years, 7 months ago (2014-05-05 21:13:17 UTC) #3
achuithb
lgtm
6 years, 7 months ago (2014-05-14 00:32:10 UTC) #4
tbarzic
The CQ bit was checked by tbarzic@chromium.org
6 years, 7 months ago (2014-05-14 02:48:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/254903002/20001
6 years, 7 months ago (2014-05-14 02:49:09 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 04:16:33 UTC) #7
achuithb
The CQ bit was unchecked by achuith@chromium.org
6 years, 7 months ago (2014-05-14 04:19:55 UTC) #8
achuithb
The CQ bit was checked by achuith@chromium.org
6 years, 7 months ago (2014-05-14 04:20:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/254903002/20001
6 years, 7 months ago (2014-05-14 04:20:38 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 04:26:31 UTC) #11
Message was sent while issue was closed.
Change committed as 270332

Powered by Google App Engine
This is Rietveld 408576698