Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2548943002: VM: Treat dynamic calls consistently in the treeshaker. (Closed)

Created:
4 years ago by Florian Schneider
Modified:
4 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Treat dynamic calls consistently in the treeshaker. Only add selector for IC calls and handle .call consistently. Slight size reduction (~10K on hello_world). R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/e0fe69da0a0e47d5536b7f460f9d4ce2fcd1d5cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M runtime/vm/precompiler.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/precompiler.cc View 2 chunks +16 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years ago (2016-12-02 22:54:41 UTC) #2
rmacnak
lgtm
4 years ago (2016-12-02 23:08:16 UTC) #3
Florian Schneider
4 years ago (2016-12-02 23:13:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e0fe69da0a0e47d5536b7f460f9d4ce2fcd1d5cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698