Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 2548923002: media: Convert GetSupportedProfiles to IsConfigSupported in MCVD (Closed)

Created:
4 years ago by watk
Modified:
4 years ago
CC:
liberato (no reviews please), chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Convert GetSupportedProfiles to IsConfigSupported in MCVD Supported profiles will not be used. Support is tested by trying to initialize the decoder. BUG=660942 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/0dfa90016056dc7ad38fe179e5f23a0cb57d6cc5 Cr-Commit-Position: refs/heads/master@{#436135}

Patch Set 1 #

Total comments: 4

Patch Set 2 : put the 4k upper limit back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -128 lines) Patch
M media/gpu/android/media_codec_video_decoder.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/gpu/android/media_codec_video_decoder.cc View 1 3 chunks +55 lines, -125 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (8 generated)
watk
https://codereview.chromium.org/2548923002/diff/1/media/gpu/android/media_codec_video_decoder.cc File media/gpu/android/media_codec_video_decoder.cc (left): https://codereview.chromium.org/2548923002/diff/1/media/gpu/android/media_codec_video_decoder.cc#oldcode1263 media/gpu/android/media_codec_video_decoder.cc:1263: VideoDecodeAccelerator::Capabilities::SUPPORTS_DEFERRED_INITIALIZATION; This is not needed. https://codereview.chromium.org/2548923002/diff/1/media/gpu/android/media_codec_video_decoder.cc#oldcode1265 media/gpu/android/media_codec_video_decoder.cc:1265: VideoDecodeAccelerator::Capabilities::NEEDS_ALL_PICTURE_BUFFERS_TO_DECODE; This ...
4 years ago (2016-12-02 22:21:15 UTC) #3
sandersd (OOO until July 31)
lgtm
4 years ago (2016-12-02 22:24:55 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2550523003 Patch 1). Please resolve the dependency and ...
4 years ago (2016-12-02 22:39:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548923002/20001
4 years ago (2016-12-03 00:32:57 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-03 01:42:12 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-03 01:45:00 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0dfa90016056dc7ad38fe179e5f23a0cb57d6cc5
Cr-Commit-Position: refs/heads/master@{#436135}

Powered by Google App Engine
This is Rietveld 408576698