components/offline_pages/background/request_coordinator.cc - Issue 2548903002: [OfflinePages] Classifies PRERENDERING_FAILED cases whether to TryNext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_coordinator.cc

Issue 2548903002: [OfflinePages] Classifies PRERENDERING_FAILED cases whether to TryNext (Closed)

Patch Set: Added a PrerenderingLoader unittest Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/background/request_coordinator.cc

diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc

index 8dcc4d94def87f3cd13e2d2d56eefe69908e5153..a745f8f4c3e4f03b96453a9bc4f269b37207a5d7 100644

--- a/components/offline_pages/background/request_coordinator.cc

+++ b/components/offline_pages/background/request_coordinator.cc

@@ -862,11 +862,12 @@ bool RequestCoordinator::ShouldTryNextRequest(

case Offliner::RequestStatus::SAVE_FAILED:

case Offliner::RequestStatus::REQUEST_COORDINATOR_CANCELED:

case Offliner::RequestStatus::REQUEST_COORDINATOR_TIMED_OUT:

+ case Offliner::RequestStatus::PRERENDERING_FAILED:

case Offliner::RequestStatus::PRERENDERING_FAILED_NO_RETRY:

return true;

case Offliner::RequestStatus::FOREGROUND_CANCELED:

case Offliner::RequestStatus::PRERENDERING_CANCELED:

- case Offliner::RequestStatus::PRERENDERING_FAILED:

+ case Offliner::RequestStatus::PRERENDERING_FAILED_NO_NEXT:

// No further processing in this service window.

return false;

default: