Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8961)

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader_unittest.cc

Issue 2548903002: [OfflinePages] Classifies PRERENDERING_FAILED cases whether to TryNext (Closed)
Patch Set: Added a PrerenderingLoader unittest Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc b/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
index ab5c6948787b14038e215d96ee96aee470be93d7..e51baa5a180eb142559bd60324090bf2dedaf6b9 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
+++ b/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
@@ -243,7 +243,7 @@ TEST_F(PrerenderingLoaderTest, LoadPageLoadSucceededFromPrerenderStopLoading) {
TEST_F(PrerenderingLoaderTest, LoadPageLoadFailedNoContent) {
test_adapter()->Configure(nullptr /* web_contents */,
- prerender::FINAL_STATUS_MEMORY_LIMIT_EXCEEDED);
+ prerender::FINAL_STATUS_CACHE_OR_HISTORY_CLEARED);
GURL gurl("http://testit.sea");
EXPECT_TRUE(loader()->IsIdle());
EXPECT_TRUE(loader()->LoadPage(
@@ -290,6 +290,31 @@ TEST_F(PrerenderingLoaderTest, LoadPageLoadFailedNoRetry) {
PumpLoop();
}
+TEST_F(PrerenderingLoaderTest, LoadPageLoadFailedNoNext) {
+ test_adapter()->Configure(nullptr /* web_contents */,
+ prerender::FINAL_STATUS_MEMORY_LIMIT_EXCEEDED);
+ GURL gurl("http://testit.sea");
+ EXPECT_TRUE(loader()->IsIdle());
+ EXPECT_TRUE(loader()->LoadPage(
+ gurl,
+ base::Bind(&PrerenderingLoaderTest::OnLoadDone, base::Unretained(this))));
+ EXPECT_FALSE(loader()->IsIdle());
+ EXPECT_FALSE(loader()->IsLoaded());
+
+ test_adapter()->GetObserver()->OnPrerenderDomContentLoaded();
+ PumpLoop();
+ EXPECT_TRUE(loader()->IsIdle());
+ EXPECT_TRUE(callback_called());
+ // We did not provide any WebContents for the callback so expect did not load.
+ // FinalStatus is non-next failure.
+ EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_FAILED_NO_NEXT,
+ callback_load_status());
+
+ // Stopped event causes no harm.
+ test_adapter()->GetObserver()->OnPrerenderStop();
+ PumpLoop();
+}
+
TEST_F(PrerenderingLoaderTest, LoadPageLoadCanceled) {
test_adapter()->Configure(nullptr /* web_contents */,
prerender::FINAL_STATUS_CANCELLED);
« no previous file with comments | « chrome/browser/android/offline_pages/prerendering_loader.cc ('k') | components/offline_pages/background/offliner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698