[OfflinePages] Classifies PRERENDERING_FAILED cases whether to TryNext

components/offline_pages/background/offliner.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_OFFLINER_H_
 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_OFFLINER_H_
 
 #include <string>
 
 #include "base/callback.h"
@@ skipping 26 matching lines @@
     // Failed to save loaded page.
     SAVE_FAILED = 6,
     // Foreground transition canceled request.
     FOREGROUND_CANCELED = 7,
     // RequestCoordinator canceled request attempt per time limit.
     REQUEST_COORDINATOR_TIMED_OUT = 8,
     // The loader did not accept/start the request.
     PRERENDERING_NOT_STARTED = 9,
     // Prerendering failed with hard error so should not retry the request.
     PRERENDERING_FAILED_NO_RETRY = 10,
+    // Prerendering failed with some error that suggests we should not continue
+    // processing another request at this time.
+    PRERENDERING_FAILED_NO_NEXT = 11,

[chili, 2016/12/02 23:17:43]

Just a thought as I'm working on the background loader...

Should we rename this to "FAILED_NO_NEXT" to make it less prerendering-specific?

[dougarnett, 2016/12/02 23:50:08]

Or LOADING_FAILED_NO_NEXT?

Pete, WDYT - should we rename the Prerendering terminology here to Loading as
part of this CL?

     // NOTE: insert new values above this line and update histogram enum too.
     STATUS_COUNT
   };
 
   // Reports the completion status of a request.
   // TODO(dougarnett): consider passing back a request id instead of request.
   typedef base::Callback<void(const SavePageRequest&, RequestStatus)>
       CompletionCallback;
 
   Offliner() {}
   virtual ~Offliner() {}
 
   // Processes |request| to load and save an offline page.
   // Returns whether the request was accepted or not. |callback| is guaranteed
   // to be called if the request was accepted and |Cancel()| is not called.
   virtual bool LoadAndSave(
       const SavePageRequest& request,
       const CompletionCallback& callback) = 0;
 
   // Clears the currently processing request, if any, and skips running its
   // CompletionCallback.
   virtual void Cancel() = 0;
 
   // TODO(dougarnett): add policy support methods.
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_BACKGROUND_OFFLINER_H_