Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2548833002: Re-enable kernel unit tests on platforms where they are supported. (Closed)

Created:
4 years ago by asgerf
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-enable kernel unit tests on platforms where they are supported. Some of them use dart:io and/or bigints so they have been disabled on browsers and JS command-line tests. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/bb92055c477f8ddcf4b6be07eef6f3d6d9c0ac03

Patch Set 1 #

Patch Set 2 : Also enable hashcode test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -614 lines) Patch
A + pkg/kernel/test/baseline_spec_mode_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/kernel/test/baseline_spec_mode_test_disabled.dart View 1 chunk +0 lines, -28 lines 0 comments Download
A + pkg/kernel/test/baseline_strong_mode_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/kernel/test/baseline_strong_mode_test_disabled.dart View 1 chunk +0 lines, -63 lines 0 comments Download
A + pkg/kernel/test/baseline_type_propagation_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/kernel/test/baseline_type_propagation_test_disabled.dart View 1 chunk +0 lines, -41 lines 0 comments Download
A + pkg/kernel/test/type_hashcode_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/test/type_hashcode_test_disabled.dart View 1 1 chunk +0 lines, -40 lines 0 comments Download
A + pkg/kernel/test/type_substitute_bounds_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/kernel/test/type_substitute_bounds_test_disabled.dart View 1 chunk +0 lines, -84 lines 0 comments Download
A + pkg/kernel/test/type_substitution_identity_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/kernel/test/type_substitution_identity_test_disabled.dart View 1 chunk +0 lines, -30 lines 0 comments Download
A + pkg/kernel/test/type_subtype_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/kernel/test/type_subtype_test_disabled.dart View 1 chunk +0 lines, -162 lines 0 comments Download
A + pkg/kernel/test/type_unification_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/kernel/test/type_unification_test_disabled.dart View 1 chunk +0 lines, -138 lines 0 comments Download
A + pkg/kernel/test/uint31_pair_map_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/kernel/test/uint31_pair_map_test_disabled.dart View 1 chunk +0 lines, -33 lines 0 comments Download
M pkg/pkg.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
4 years ago (2016-12-02 17:09:17 UTC) #2
Kevin Millikin (Google)
LGTM.
4 years ago (2016-12-05 10:03:57 UTC) #3
asgerf
4 years ago (2016-12-05 10:35:47 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
bb92055c477f8ddcf4b6be07eef6f3d6d9c0ac03 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698