Source/core/rendering/RenderMultiColumnSet.h - Issue 254883003: [New Multicolumn] Faster and more direct RenderMultiColumnSet::multiColumnFlowThread().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMultiColumnSet.h

Issue 254883003: [New Multicolumn] Faster and more direct RenderMultiColumnSet::multiColumnFlowThread(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Also call multiColumnFlowThread() in favor of multicolBlock->multiColumnFlowThread() Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RenderMultiColumnFlowThread.h ('K') | « Source/core/rendering/RenderMultiColumnFlowThread.h ('k') | Source/core/rendering/RenderMultiColumnSet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderMultiColumnSet.h

diff --git a/Source/core/rendering/RenderMultiColumnSet.h b/Source/core/rendering/RenderMultiColumnSet.h

index 98a68bfa14b2d9323c551de085dfee272016efee..29ec4f252dc003051e58f5c8308fd7155175199c 100644

--- a/Source/core/rendering/RenderMultiColumnSet.h

+++ b/Source/core/rendering/RenderMultiColumnSet.h

@@ -27,6 +27,7 @@

#ifndef RenderMultiColumnSet_h

#define RenderMultiColumnSet_h

+#include "core/rendering/RenderMultiColumnFlowThread.h"

#include "core/rendering/RenderRegionSet.h"

#include "wtf/Vector.h"

@@ -56,7 +57,13 @@ public:

virtual bool isRenderMultiColumnSet() const OVERRIDE { return true; }

RenderBlockFlow* multiColumnBlockFlow() const { return toRenderBlockFlow(parent()); }

- RenderMultiColumnFlowThread* multiColumnFlowThread() const { return multiColumnBlockFlow()->multiColumnFlowThread(); }

+ RenderMultiColumnFlowThread* multiColumnFlowThread() const

+ {

+#ifndef NDEBUG

+ ASSERT_WITH_SECURITY_IMPLICATION(!flowThread() || flowThread()->isRenderMultiColumnFlowThread());

+#endif // NDEBUG

+ return static_cast<RenderMultiColumnFlowThread*>(flowThread());

+ }

RenderMultiColumnSet* nextSiblingMultiColumnSet() const;