Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: Source/core/rendering/RenderMultiColumnFlowThread.h

Issue 254883003: [New Multicolumn] Faster and more direct RenderMultiColumnSet::multiColumnFlowThread(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Code review #2 Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderFlowThread.h ('k') | Source/core/rendering/RenderMultiColumnSet.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 // is unbreakable and cannot fully fit in the same column as the preceding piece of 49 // is unbreakable and cannot fully fit in the same column as the preceding piece of
50 // content. Although a RenderMultiColumnFlowThread is laid out, it does not take up any space in its 50 // content. Although a RenderMultiColumnFlowThread is laid out, it does not take up any space in its
51 // container. It's the RenderMultiColumnSet objects that take up the necessary a mount of space, and 51 // container. It's the RenderMultiColumnSet objects that take up the necessary a mount of space, and
52 // make sure that the columns are painted and hit-tested correctly. 52 // make sure that the columns are painted and hit-tested correctly.
53 class RenderMultiColumnFlowThread FINAL : public RenderFlowThread { 53 class RenderMultiColumnFlowThread FINAL : public RenderFlowThread {
54 public: 54 public:
55 virtual ~RenderMultiColumnFlowThread(); 55 virtual ~RenderMultiColumnFlowThread();
56 56
57 static RenderMultiColumnFlowThread* createAnonymous(Document&, RenderStyle* parentStyle); 57 static RenderMultiColumnFlowThread* createAnonymous(Document&, RenderStyle* parentStyle);
58 58
59 virtual bool isRenderMultiColumnFlowThread() const OVERRIDE FINAL { return t rue; }
60
59 RenderBlockFlow* multiColumnBlockFlow() const { return toRenderBlockFlow(par ent()); } 61 RenderBlockFlow* multiColumnBlockFlow() const { return toRenderBlockFlow(par ent()); }
60 62
61 RenderMultiColumnSet* firstMultiColumnSet() const; 63 RenderMultiColumnSet* firstMultiColumnSet() const;
62 RenderMultiColumnSet* lastMultiColumnSet() const; 64 RenderMultiColumnSet* lastMultiColumnSet() const;
63 65
64 virtual void addChild(RenderObject* newChild, RenderObject* beforeChild = 0) OVERRIDE; 66 virtual void addChild(RenderObject* newChild, RenderObject* beforeChild = 0) OVERRIDE;
65 67
66 // Populate the flow thread with what's currently its siblings. Called when a regular block 68 // Populate the flow thread with what's currently its siblings. Called when a regular block
67 // becomes a multicol container. 69 // becomes a multicol container.
68 void populate(); 70 void populate();
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 LayoutUnit m_columnWidth; // The used value of column-width 102 LayoutUnit m_columnWidth; // The used value of column-width
101 LayoutUnit m_columnHeightAvailable; // Total height available to columns, or 0 if auto. 103 LayoutUnit m_columnHeightAvailable; // Total height available to columns, or 0 if auto.
102 bool m_inBalancingPass; // Set when relayouting for column balancing. 104 bool m_inBalancingPass; // Set when relayouting for column balancing.
103 bool m_needsRebalancing; 105 bool m_needsRebalancing;
104 }; 106 };
105 107
106 } // namespace WebCore 108 } // namespace WebCore
107 109
108 #endif // RenderMultiColumnFlowThread_h 110 #endif // RenderMultiColumnFlowThread_h
109 111
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderFlowThread.h ('k') | Source/core/rendering/RenderMultiColumnSet.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698