Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: Source/core/rendering/RenderMultiColumnFlowThread.h

Issue 254883003: [New Multicolumn] Faster and more direct RenderMultiColumnSet::multiColumnFlowThread(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Also call multiColumnFlowThread() in favor of multicolBlock->multiColumnFlowThread() Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 // is unbreakable and cannot fully fit in the same column as the preceding piece of 49 // is unbreakable and cannot fully fit in the same column as the preceding piece of
50 // content. Although a RenderMultiColumnFlowThread is laid out, it does not take up any space in its 50 // content. Although a RenderMultiColumnFlowThread is laid out, it does not take up any space in its
51 // container. It's the RenderMultiColumnSet objects that take up the necessary a mount of space, and 51 // container. It's the RenderMultiColumnSet objects that take up the necessary a mount of space, and
52 // make sure that the columns are painted and hit-tested correctly. 52 // make sure that the columns are painted and hit-tested correctly.
53 class RenderMultiColumnFlowThread FINAL : public RenderFlowThread { 53 class RenderMultiColumnFlowThread FINAL : public RenderFlowThread {
54 public: 54 public:
55 virtual ~RenderMultiColumnFlowThread(); 55 virtual ~RenderMultiColumnFlowThread();
56 56
57 static RenderMultiColumnFlowThread* createAnonymous(Document&, RenderStyle* parentStyle); 57 static RenderMultiColumnFlowThread* createAnonymous(Document&, RenderStyle* parentStyle);
58 58
59 #ifndef NDEBUG
60 // This one is only used in assertions at the moment.
rune 2014/04/30 11:00:12 "one" -> "method"?
mstensho (USE GERRIT) 2014/04/30 11:05:06 Done.
61 virtual bool isRenderMultiColumnFlowThread() const OVERRIDE FINAL { return t rue; }
62 #endif // NDEBUG
63
59 RenderBlockFlow* multiColumnBlockFlow() const { return toRenderBlockFlow(par ent()); } 64 RenderBlockFlow* multiColumnBlockFlow() const { return toRenderBlockFlow(par ent()); }
60 65
61 RenderMultiColumnSet* firstMultiColumnSet() const; 66 RenderMultiColumnSet* firstMultiColumnSet() const;
62 RenderMultiColumnSet* lastMultiColumnSet() const; 67 RenderMultiColumnSet* lastMultiColumnSet() const;
63 68
64 virtual void addChild(RenderObject* newChild, RenderObject* beforeChild = 0) OVERRIDE; 69 virtual void addChild(RenderObject* newChild, RenderObject* beforeChild = 0) OVERRIDE;
65 70
66 // Populate the flow thread with what's currently its siblings. Called when a regular block 71 // Populate the flow thread with what's currently its siblings. Called when a regular block
67 // becomes a multicol container. 72 // becomes a multicol container.
68 void populate(); 73 void populate();
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 LayoutUnit m_columnWidth; // The used value of column-width 105 LayoutUnit m_columnWidth; // The used value of column-width
101 LayoutUnit m_columnHeightAvailable; // Total height available to columns, or 0 if auto. 106 LayoutUnit m_columnHeightAvailable; // Total height available to columns, or 0 if auto.
102 bool m_inBalancingPass; // Set when relayouting for column balancing. 107 bool m_inBalancingPass; // Set when relayouting for column balancing.
103 bool m_needsRebalancing; 108 bool m_needsRebalancing;
104 }; 109 };
105 110
106 } // namespace WebCore 111 } // namespace WebCore
107 112
108 #endif // RenderMultiColumnFlowThread_h 113 #endif // RenderMultiColumnFlowThread_h
109 114
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698