Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2548823002: Spellcheck : Fix caching in cases where text is deleted. (Closed)

Created:
4 years ago by timvolodine
Modified:
4 years ago
Reviewers:
Tobias Sargeant
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org, timvolodine
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Spellcheck : Fix caching in cases where text is deleted. Merge to M56 (branch 2924) This patch fixes spellcheck caching in the following case: 1. paragraph is edited by removing text from the back and 2. paragraph does not contain misspelled words. Currently this case results in a cache miss and consequently spellcheck requests being sent to the spellchecking service while completely unnecessary. This fix applies to all platforms. This patch also adds a few unit tests for the relevant caching specific behavior. BUG=664247, 629609 TBR=tobiasjs@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2494123002 Cr-Commit-Position: refs/heads/master@{#434710} (cherry picked from commit cb1e0169211135db1dd2e0220434bcec2efd7f16)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -11 lines) Patch
M components/spellcheck/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/spellcheck/renderer/spellcheck_provider.cc View 1 chunk +4 lines, -11 lines 0 comments Download
M components/spellcheck/renderer/spellcheck_provider_test.h View 1 chunk +6 lines, -0 lines 0 comments Download
M components/spellcheck/renderer/spellcheck_provider_test.cc View 1 chunk +13 lines, -0 lines 0 comments Download
A components/spellcheck/renderer/spellcheck_provider_unittest.cc View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
timvolodine
merge to M56 of https://codereview.chromium.org/2494123002/
4 years ago (2016-12-02 16:04:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548823002/1
4 years ago (2016-12-02 16:04:55 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-02 16:09:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698