Issue 25488002: dbus: Add ObjectProxy::WaitForServiceToBeAvailable()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25488002: dbus: Add ObjectProxy::WaitForServiceToBeAvailable() (Closed)

Created:
7 years, 2 months ago by hashimoto

Modified:
7 years, 2 months ago

Reviewers:
satorux1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

dbus: Add ObjectProxy::WaitForServiceToBeAvailable() Split ConnectToNameOwnerChangedSignal() from ConnectToSignalInternal(). Add WaitForServiceToBeAvailable() Add test. BUG=141009 TEST=dbus_unittests R=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226428

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+170 lines, -14 lines)			Patch
M	dbus/dbus.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	dbus/object_proxy.h	View		5 chunks	+21 lines, -0 lines	0 comments	Download
M	dbus/object_proxy.cc	View		7 chunks	+72 lines, -14 lines	0 comments	Download
A	dbus/object_proxy_unittest.cc	View	1	1 chunk	+76 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

satorux1

LGTM. Do you plan to use WaitForServiceToBeAvailable() from client code? It might be easier to ...

7 years, 2 months ago (2013-10-02 04:44:12 UTC) #2

hashimoto

7 years, 2 months ago (2013-10-02 07:53:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r226428 (presubmit successful).