Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2548753003: [ic] Ensure state of load/store ICs always progresses. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Ensure state of load/store ICs always progresses. ... even when a receiver is not an object. BUG=v8:5697 Committed: https://crrev.com/e7a51fff24d08afb0f777f60f1a675a12c3555de Cr-Commit-Position: refs/heads/master@{#41458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M src/counters.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +14 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-v8-5697.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-02 11:16:42 UTC) #4
Igor Sheludko
PTAL
4 years ago (2016-12-02 14:35:18 UTC) #9
Camillo Bruni
lgtm
4 years ago (2016-12-02 15:04:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548753003/1
4 years ago (2016-12-02 15:05:27 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 15:07:08 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-02 15:07:43 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7a51fff24d08afb0f777f60f1a675a12c3555de
Cr-Commit-Position: refs/heads/master@{#41458}

Powered by Google App Engine
This is Rietveld 408576698