Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 2548693003: [Merge M56][translate] Fix enforcement vs logging for TranslateRanker. (Closed)

Created:
4 years ago by Mathieu
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Merge M56][translate] Fix enforcement vs logging for TranslateRanker. The translate ranker enforcement flag was redundantly enforced within the ranker itself, thwarting the TranslateManagers attempts to log the ranker result and enforc (or not) the result. The check in the TranslateRanker should have been removed in the last refactor. BUG=669528 Review-Url: https://codereview.chromium.org/2533953003 Cr-Commit-Position: refs/heads/master@{#435061} (cherry picked from commit 131e0dc96c8c88fc1fc222442a61fb2704b1795d) Committed: https://chromium.googlesource.com/chromium/src/+/f5e19ee30ef13c7a28686f16809a582c818dcbce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M components/translate/core/browser/translate_ranker.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Mathieu
4 years ago (2016-12-02 20:22:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f5e19ee30ef13c7a28686f16809a582c818dcbce (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698