Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2548693002: Editorial changes to layout tests writing document. (Closed)

Created:
4 years ago by pwnall
Modified:
4 years ago
Reviewers:
jsbell
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Editorial changes to layout tests writing document. This CL converts a massive linked list into a series of sub-headings. Asides from readability improvements, switching to headings makes it possible to link to individual guidelines, which may be desirable in discussions or code reviews. BUG= Committed: https://crrev.com/6acacd84959061cd7e2e8db7f5da3d5426e838a4 Cr-Commit-Position: refs/heads/master@{#435813}

Patch Set 1 #

Patch Set 2 : Addressed feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -158 lines) Patch
M docs/testing/writing_layout_tests.md View 1 9 chunks +260 lines, -158 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
pwnall
I reformatted the Principles section and tried to point out the recommendations which are still ...
4 years ago (2016-12-02 00:25:18 UTC) #2
jsbell
In the CL description, "linked list" - you mean bulleted list?
4 years ago (2016-12-02 00:45:35 UTC) #3
jsbell
Silly suggestion: Put 🚧 at the start of stuff that's under discussion? Possibly add to ...
4 years ago (2016-12-02 00:52:43 UTC) #4
jsbell
oh, and lgtm
4 years ago (2016-12-02 00:53:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548693002/20001
4 years ago (2016-12-02 01:30:04 UTC) #8
pwnall
Thank you very much for the feedback! On 2016/12/02 00:52:43, jsbell wrote: > Silly suggestion: ...
4 years ago (2016-12-02 01:31:37 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-02 01:40:42 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-02 01:42:13 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6acacd84959061cd7e2e8db7f5da3d5426e838a4
Cr-Commit-Position: refs/heads/master@{#435813}

Powered by Google App Engine
This is Rietveld 408576698