Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2548663002: [Devtools] Rename logEntries to node in network (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 516 matching lines...) Expand 10 before | Expand all | Expand 10 after
527 this._setHoveredNode(node, highlightInitiatorChain); 527 this._setHoveredNode(node, highlightInitiatorChain);
528 this._highlightInitiatorChain((highlightInitiatorChain && node) ? node.reque st() : null); 528 this._highlightInitiatorChain((highlightInitiatorChain && node) ? node.reque st() : null);
529 } 529 }
530 530
531 _dataGridMouseLeave() { 531 _dataGridMouseLeave() {
532 this._setHoveredNode(null); 532 this._setHoveredNode(null);
533 this._highlightInitiatorChain(null); 533 this._highlightInitiatorChain(null);
534 } 534 }
535 535
536 /** 536 /**
537 * @param {?Network.NetworkLogEntry} logEntry 537 * @param {?Network.NetworkDataGridNode} node
538 * @param {boolean} highlightInitiatorChain 538 * @param {boolean} highlightInitiatorChain
539 */ 539 */
540 setHoveredLogEntry(logEntry, highlightInitiatorChain) { 540 setHoveredNode(node, highlightInitiatorChain) {
541 // TODO(allada) Move this into LogEntry/NetworkDataGridNode. 541 this._setHoveredNode(node, highlightInitiatorChain);
542 this._setHoveredNode(/** @type {?Network.NetworkDataGridNode} */ (logEntry), highlightInitiatorChain); 542 this._highlightInitiatorChain((node && highlightInitiatorChain) ? node.reque st() : null);
543 this._highlightInitiatorChain((logEntry && highlightInitiatorChain) ? logEnt ry.request() : null);
544 } 543 }
545 544
546 /** 545 /**
547 * @param {?Network.NetworkDataGridNode} node 546 * @param {?Network.NetworkDataGridNode} node
548 * @param {boolean=} highlightInitiatorChain 547 * @param {boolean=} highlightInitiatorChain
549 */ 548 */
550 _setHoveredNode(node, highlightInitiatorChain) { 549 _setHoveredNode(node, highlightInitiatorChain) {
551 if (this._hoveredNode) 550 if (this._hoveredNode)
552 this._hoveredNode.element().classList.remove('hover'); 551 this._hoveredNode.element().classList.remove('hover');
553 this._hoveredNode = node; 552 this._hoveredNode = node;
554 if (this._hoveredNode) 553 if (this._hoveredNode)
555 this._hoveredNode.element().classList.add('hover'); 554 this._hoveredNode.element().classList.add('hover');
556 this._columns.setHoveredLogEntry(this._hoveredNode, !!highlightInitiatorChai n); 555 this._columns.setHoveredNode(this._hoveredNode, !!highlightInitiatorChain);
557 } 556 }
558 557
559 /** 558 /**
560 * @param {!Event} event 559 * @param {!Event} event
561 */ 560 */
562 _dataGridMouseDown(event) { 561 _dataGridMouseDown(event) {
563 if (!this._dataGrid.selectedNode && event.button) 562 if (!this._dataGrid.selectedNode && event.button)
564 event.consume(); 563 event.consume();
565 } 564 }
566 565
(...skipping 1149 matching lines...) Expand 10 before | Expand all | Expand 10 after
1716 Running: 'running', 1715 Running: 'running',
1717 FromCache: 'from-cache' 1716 FromCache: 'from-cache'
1718 }; 1717 };
1719 1718
1720 /** @type {!Array<string>} */ 1719 /** @type {!Array<string>} */
1721 Network.NetworkLogView._searchKeys = 1720 Network.NetworkLogView._searchKeys =
1722 Object.keys(Network.NetworkLogView.FilterType).map(key => Network.NetworkLog View.FilterType[key]); 1721 Object.keys(Network.NetworkLogView.FilterType).map(key => Network.NetworkLog View.FilterType[key]);
1723 1722
1724 /** @typedef {function(!SDK.NetworkRequest): boolean} */ 1723 /** @typedef {function(!SDK.NetworkRequest): boolean} */
1725 Network.NetworkLogView.Filter; 1724 Network.NetworkLogView.Filter;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698