Use TaskScheduler instead of WorkerPool in recovery_component_installer.cc.

Use TaskScheduler instead of WorkerPool in recovery_component_installer.cc.

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits() call. The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

With/without file IO:
  This CL contains both tasks that are allowed to perform synchronous
  IO operations and tasks that aren't.

With/without Wait:
  This CL contains both tasks that wait on things other than synchronous
  file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread,
  join a process, blocking system call that doesn't involve interactions with
  the file system) and tasks that don't.

TBR=jochen@chromium.org
BUG=659191
Committed: https://crrev.com/5695589b87938486b24f0e1f6dfb761ab7915ed1
Cr-Commit-Position: refs/heads/master@{#436787}

[fdoray, 2016-12-01 21:41:31]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 21:42:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-12-01 21:43:22]

Description was changed from

==========
Use TaskScheduler instead of WorkerPool in recovery_component_installer.cc.

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits() call. The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

With file IO:
  The task is allowed to perform synchronous IO operations.

With Wait:
  The task waits on things other than synchronous file IO
  operations (e.g. WaitableEvent, ConditionVariable, join a thread,
  join a process, blocking system call that doesn't involve
  interactions with the file system).

BUG=659191
==========

to

==========
Use TaskScheduler instead of WorkerPool in recovery_component_installer.cc.

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits() call. The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

With/without file IO:
  This CL contains both tasks that are allowed to perform synchronous
  IO operations and tasks that aren't.

With/without Wait:
  This CL contains both tasks that wait on things other than synchronous
  file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread,
  join a process, blocking system call that doesn't involve interactions with
  the file system) and tasks that don't.

BUG=659191
==========

[commit-bot: I haz the power, 2016-12-01 22:26:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 22:26:36]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-12-02 13:27:06]

fdoray@chromium.org changed reviewers:
+ jochen@chromium.org

[fdoray, 2016-12-02 13:27:06]

Please review this CL. In particular, make sure that the traits mentioned in the
CL description make sense for this task. Thanks!

Note: WorkerPool is being deprecated in favor of TaskScheduler. Read the design
doc
https://docs.google.com/document/d/1S2AAeoo1xa_vsLbDYBsDHCqhrkfiMgoIPlyRi6kxa...

Note: On shutdown, WorkerPool does not wait for tasks to run. To get the same
behavior in TaskScheduler, we used TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN.

[jochen (gone - plz use gerrit), 2016-12-05 15:34:27]

same here, no idea what the code needs

[fdoray, 2016-12-06 21:03:36]

fdoray@chromium.org changed reviewers:
+ robertshield@chromium.org

[fdoray, 2016-12-06 21:03:36]

robertshield@: PTAL. In particular, make sure that the traits mentioned in the
CL description make sense for this task. Thanks!

[robertshield, 2016-12-06 21:20:41]

robertshield@chromium.org changed reviewers:
+ xiaolingbao@chromium.org

[robertshield, 2016-12-06 21:20:41]

Thanks for a super detailed CL description. 

The traits described LGTM, suggest running this by Xiaoling (owner of recovery
component) to double check.

[fdoray, 2016-12-06 21:28:54]

xiaoling@: PTAL

[xiaoling, 2016-12-06 22:03:41]

lgtm

[xiaoling, 2016-12-06 22:03:42]

lgtm

[fdoray, 2016-12-06 22:05:53]

Description was changed from

==========
Use TaskScheduler instead of WorkerPool in recovery_component_installer.cc.

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits() call. The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

With/without file IO:
  This CL contains both tasks that are allowed to perform synchronous
  IO operations and tasks that aren't.

With/without Wait:
  This CL contains both tasks that wait on things other than synchronous
  file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread,
  join a process, blocking system call that doesn't involve interactions with
  the file system) and tasks that don't.

BUG=659191
==========

to

==========
Use TaskScheduler instead of WorkerPool in recovery_component_installer.cc.

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits() call. The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

With/without file IO:
  This CL contains both tasks that are allowed to perform synchronous
  IO operations and tasks that aren't.

With/without Wait:
  This CL contains both tasks that wait on things other than synchronous
  file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread,
  join a process, blocking system call that doesn't involve interactions with
  the file system) and tasks that don't.

TBR=jochen@chromium.org
BUG=659191
==========

[fdoray, 2016-12-06 22:06:24]

On 2016/12/06 22:03:42, xiaoling wrote:
> lgtm

TBR=jochen@chromium.org - OWNER

[fdoray, 2016-12-06 22:06:32]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-12-06 22:07:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 00:41:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481061992901680, "parent_rev":
"1d6e7a98b49eeef3b2ce821f28c3b910fe33739a", "commit_rev":
"1155fa4e299ba87f6c80f2325aef2b5ab038b954"}

[commit-bot: I haz the power, 2016-12-07 00:42:00]

Description was changed from

==========
Use TaskScheduler instead of WorkerPool in recovery_component_installer.cc.

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits() call. The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

With/without file IO:
  This CL contains both tasks that are allowed to perform synchronous
  IO operations and tasks that aren't.

With/without Wait:
  This CL contains both tasks that wait on things other than synchronous
  file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread,
  join a process, blocking system call that doesn't involve interactions with
  the file system) and tasks that don't.

TBR=jochen@chromium.org
BUG=659191
==========

to

==========
Use TaskScheduler instead of WorkerPool in recovery_component_installer.cc.

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits() call. The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

With/without file IO:
  This CL contains both tasks that are allowed to perform synchronous
  IO operations and tasks that aren't.

With/without Wait:
  This CL contains both tasks that wait on things other than synchronous
  file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread,
  join a process, blocking system call that doesn't involve interactions with
  the file system) and tasks that don't.

TBR=jochen@chromium.org
BUG=659191
==========

[commit-bot: I haz the power, 2016-12-07 00:42:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-07 00:45:58]

Description was changed from

==========
Use TaskScheduler instead of WorkerPool in recovery_component_installer.cc.

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits() call. The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

With/without file IO:
  This CL contains both tasks that are allowed to perform synchronous
  IO operations and tasks that aren't.

With/without Wait:
  This CL contains both tasks that wait on things other than synchronous
  file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread,
  join a process, blocking system call that doesn't involve interactions with
  the file system) and tasks that don't.

TBR=jochen@chromium.org
BUG=659191
==========

to

==========
Use TaskScheduler instead of WorkerPool in recovery_component_installer.cc.

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits() call. The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

With/without file IO:
  This CL contains both tasks that are allowed to perform synchronous
  IO operations and tasks that aren't.

With/without Wait:
  This CL contains both tasks that wait on things other than synchronous
  file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread,
  join a process, blocking system call that doesn't involve interactions with
  the file system) and tasks that don't.

TBR=jochen@chromium.org
BUG=659191

Committed: https://crrev.com/5695589b87938486b24f0e1f6dfb761ab7915ed1
Cr-Commit-Position: refs/heads/master@{#436787}
==========

[commit-bot: I haz the power, 2016-12-07 00:45:59]

Patchset 1 (id:??) landed as
https://crrev.com/5695589b87938486b24f0e1f6dfb761ab7915ed1
Cr-Commit-Position: refs/heads/master@{#436787}