Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2548583003: Revert of [typedarrays] remove invalid optimization in NAMEConstructor() (Closed)

Created:
4 years ago by enne (OOO)
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [typedarrays] remove invalid optimization in NAMEConstructor() (patchset #1 id:1 of https://codereview.chromium.org/2544503002/ ) Reason for revert: Speculative revert for causing timeouts on Win Debug gpu fyi bot Nothing else looks even remotely relevant in the list of changes. Will reland if this doesn't fix the issues. BUG=670396 Original issue's description: > [typedarrays] remove invalid optimization in NAMEConstructor() > > Before, we were treating objects with the builtin ArrayValues iterator > method as array-like, where the iterator would iterate through to the > full length of the object. > > This optimization was not sound, because it does not ensure that the > next method hasn't been modified. Even if it hasn't been modified, > it's entirely possible to be modified during iteration. Thus, this > optimization has been removed due to its observability. > > BUG=v8:5699 > R=littledan@chromium.org, cbruni@chromium.org > > Committed: https://crrev.com/77df8c67d9609ada3b7d79e8e6d33f198bbad5a1 > Cr-Commit-Position: refs/heads/master@{#41394} TBR=cbruni@chromium.org,littledan@chromium.org,caitp@igalia.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5699 Committed: https://crrev.com/0ea4a542202d501c4e550474e89512532571f3a0 Cr-Commit-Position: refs/heads/master@{#41461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -26 lines) Patch
M src/js/typedarray.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/typedarray.js View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
enne (OOO)
Created Revert of [typedarrays] remove invalid optimization in NAMEConstructor()
4 years ago (2016-12-01 22:15:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548583003/1
4 years ago (2016-12-01 22:15:29 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-01 22:15:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548583003/1
4 years ago (2016-12-02 18:45:51 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-02 18:45:52 UTC) #13
Dan Ehrenberg
lgtm lgtm Speculative revert--performance degradation may have caused test timeouts.
4 years ago (2016-12-02 18:46:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548583003/1
4 years ago (2016-12-02 18:46:21 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 18:48:24 UTC) #18
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0ea4a542202d501c4e550474e89512532571f3a0 Cr-Commit-Position: refs/heads/master@{#41461}
4 years ago (2016-12-02 18:48:43 UTC) #20
ynovikov
4 years ago (2016-12-05 20:58:40 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2553873002/ by ynovikov@chromium.org.

The reason for reverting is: The bot was not affected by the revert. Speculation
was wrong..

Powered by Google App Engine
This is Rietveld 408576698