Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2548573004: Ensure conservative raster clipping for AnalysisCanvas (Closed)

Created:
4 years ago by f(malita)
Modified:
4 years ago
Reviewers:
reed1
CC:
chromium-reviews, vmiura, chrishtr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure conservative raster clipping for AnalysisCanvas Inherit from SkNoDrawCanvas, which uses conservative clipping. BUG=668925 R=reed@google.com Committed: https://crrev.com/ae0797ad640d7b8f55de130790ddc32583f059ab Cr-Commit-Position: refs/heads/master@{#435979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M skia/ext/analysis_canvas.h View 3 chunks +4 lines, -3 lines 0 comments Download
M skia/ext/analysis_canvas.cc View 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
f(malita)
4 years ago (2016-12-02 16:19:52 UTC) #4
reed1
lgtm
4 years ago (2016-12-02 18:08:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548573004/1
4 years ago (2016-12-02 18:13:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 18:17:17 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-02 18:19:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae0797ad640d7b8f55de130790ddc32583f059ab
Cr-Commit-Position: refs/heads/master@{#435979}

Powered by Google App Engine
This is Rietveld 408576698