Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2548573003: Drop SVGElement::accessDocumentSVGExtensions() (Closed)

Created:
4 years ago by fs
Modified:
4 years ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop SVGElement::accessDocumentSVGExtensions() This method has a single user into which it can be folded without any issues. The comment in the method seem to no longer apply. Also drop an unused friend declaration while at it. Committed: https://crrev.com/2d849ba6e9dfed83df0afa2093baae58effdbff2 Cr-Commit-Position: refs/heads/master@{#436051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M third_party/WebKit/Source/core/svg/SVGElement.h View 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
fs
4 years ago (2016-12-02 21:05:19 UTC) #6
pdr.
On 2016/12/02 at 21:05:19, fs wrote: > LGTM
4 years ago (2016-12-02 21:14:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548573003/1
4 years ago (2016-12-02 21:16:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 22:19:47 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-02 22:23:05 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d849ba6e9dfed83df0afa2093baae58effdbff2
Cr-Commit-Position: refs/heads/master@{#436051}

Powered by Google App Engine
This is Rietveld 408576698