Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGAnimatedEnumerationBase.cpp

Issue 2548533003: Avoid repeating ourselves in SVGAnimatedEnumerationBase::setBaseVal (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 } 45 }
46 46
47 if (value > baseValue()->maxExposedEnumValue()) { 47 if (value > baseValue()->maxExposedEnumValue()) {
48 exceptionState.throwTypeError( 48 exceptionState.throwTypeError(
49 "The enumeration value provided (" + String::number(value) + 49 "The enumeration value provided (" + String::number(value) +
50 ") is larger than the largest allowed value (" + 50 ") is larger than the largest allowed value (" +
51 String::number(baseValue()->maxExposedEnumValue()) + ")."); 51 String::number(baseValue()->maxExposedEnumValue()) + ").");
52 return; 52 return;
53 } 53 }
54 54
55 baseValue()->setValue(value); 55 SVGAnimatedProperty<SVGEnumerationBase>::setBaseVal(value, exceptionState);
56
57 m_baseValueUpdated = true;
58
59 ASSERT(this->attributeName() != QualifiedName::null());
60 contextElement()->invalidateSVGAttributes();
61 contextElement()->svgAttributeBaseValChanged(this->attributeName());
62 } 56 }
63 57
64 } // namespace blink 58 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698