Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: ui/aura/mus/window_tree_client.cc

Issue 2548513002: Update bool WindowManager::OnWmSetBounds() to match with its desirable behavior. (Closed)
Patch Set: Remove if condition statetment in Window::SetBounds(const gfx::Rect& new_bounds). Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/aura/mus/window_tree_client.cc
diff --git a/ui/aura/mus/window_tree_client.cc b/ui/aura/mus/window_tree_client.cc
index 03c333e8f365cbe8eb568f28ca76010030177651..d56616f4c5a3a01f3501c1f387099194cf0b9295 100644
--- a/ui/aura/mus/window_tree_client.cc
+++ b/ui/aura/mus/window_tree_client.cc
@@ -1302,22 +1302,17 @@ void WindowTreeClient::WmSetBounds(uint32_t change_id,
Id window_id,
const gfx::Rect& transit_bounds) {
WindowMus* window = GetWindowByServerId(window_id);
- bool result = false;
if (window) {
DCHECK(window_manager_delegate_);
- gfx::Rect bounds = transit_bounds;
// TODO: this needs to trigger scheduling a bounds change on |window|.
- result =
- window_manager_delegate_->OnWmSetBounds(window->GetWindow(), &bounds);
- if (result) {
- // If the resulting bounds differ return false. Returning false ensures
- // the client applies the bounds we set below.
- result = bounds == transit_bounds;
- window->SetBoundsFromServer(bounds);
- }
+ window_manager_delegate_->OnWmSetBounds(window->GetWindow(),
+ transit_bounds);
}
+
+ // Returning false ensures the client applies the bounds we set above in the
+ // delegate.
mfomitchev 2016/12/08 20:44:23 Ditto
if (window_manager_internal_client_)
- window_manager_internal_client_->WmResponse(change_id, result);
+ window_manager_internal_client_->WmResponse(change_id, false);
}
void WindowTreeClient::WmSetProperty(

Powered by Google App Engine
This is Rietveld 408576698