Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: mash/simple_wm/simple_wm.cc

Issue 2548513002: Update bool WindowManager::OnWmSetBounds() to match with its desirable behavior. (Closed)
Patch Set: Change gfx::Rect* to const gfx::Rect&. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mash/simple_wm/simple_wm.cc
diff --git a/mash/simple_wm/simple_wm.cc b/mash/simple_wm/simple_wm.cc
index 49917e298038468c406f6f578fbb3b05073c1366..514081af93ae45a6cbacbedf077c4ab44340da70 100644
--- a/mash/simple_wm/simple_wm.cc
+++ b/mash/simple_wm/simple_wm.cc
@@ -138,10 +138,9 @@ void SimpleWM::SetWindowManagerClient(
window_manager_client_ = client;
}
-bool SimpleWM::OnWmSetBounds(aura::Window* window, gfx::Rect* bounds) {
+void SimpleWM::OnWmSetBounds(aura::Window* window, gfx::Rect* bounds) {
mfomitchev 2016/12/07 20:59:46 Update the signature.
mfomitchev 2016/12/07 20:59:46 Here and in all other implementations - I think we
thanhph 2016/12/08 00:20:29 Done.
mfomitchev 2016/12/08 20:44:23 See also my other comment above - I think we need
FrameView* frame_view = GetFrameViewForClientWindow(window);
frame_view->GetWidget()->SetBounds(*bounds);
- return true;
}
bool SimpleWM::OnWmSetProperty(

Powered by Google App Engine
This is Rietveld 408576698