Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: ui/aura/mus/window_tree_client.cc

Issue 2548513002: Update bool WindowManager::OnWmSetBounds() to match with its desirable behavior. (Closed)
Patch Set: revert ui::window to aura::window. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/aura/mus/window_tree_client.cc
diff --git a/ui/aura/mus/window_tree_client.cc b/ui/aura/mus/window_tree_client.cc
index d318eabb0b74f55278dc65f4ed8429d9888ab996..f8e91eae0528f4835fbb23d89b561e676f74d339 100644
--- a/ui/aura/mus/window_tree_client.cc
+++ b/ui/aura/mus/window_tree_client.cc
@@ -1302,22 +1302,13 @@ void WindowTreeClient::WmSetBounds(uint32_t change_id,
Id window_id,
const gfx::Rect& transit_bounds) {
WindowMus* window = GetWindowByServerId(window_id);
- bool result = false;
if (window) {
DCHECK(window_manager_delegate_);
- gfx::Rect bounds = transit_bounds;
// TODO: this needs to trigger scheduling a bounds change on |window|.
- result =
- window_manager_delegate_->OnWmSetBounds(window->GetWindow(), &bounds);
- if (result) {
- // If the resulting bounds differ return false. Returning false ensures
- // the client applies the bounds we set below.
- result = bounds == transit_bounds;
- window->SetBoundsFromServer(bounds);
- }
+ window->SetBoundsFromServer(transit_bounds);
mfomitchev 2016/12/06 20:55:20 Same here - don't we still need to call OnWmSetBou
thanhph 2016/12/06 21:41:04 I still the same argument as above. window->SetBou
thanhph 2016/12/07 20:48:12 Done, I added back window_manager_delegate_->OnWmS
}
if (window_manager_internal_client_)
- window_manager_internal_client_->WmResponse(change_id, result);
+ window_manager_internal_client_->WmResponse(change_id, false);
Fady Samuel 2016/12/06 20:50:08 I'm confused about this. Shouldn't the second argu
thanhph 2016/12/06 21:41:04 Same answer as your above comment.
}
void WindowTreeClient::WmSetProperty(

Powered by Google App Engine
This is Rietveld 408576698