Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: services/ui/public/cpp/window_tree_client.cc

Issue 2548513002: Update bool WindowManager::OnWmSetBounds() to match with its desirable behavior. (Closed)
Patch Set: revert ui::window to aura::window. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/public/cpp/window_tree_client.cc
diff --git a/services/ui/public/cpp/window_tree_client.cc b/services/ui/public/cpp/window_tree_client.cc
index d708659579205421d5a12514b49c8d8151ff75d5..8cc741376af290ce8d47283a8159e018ad48ed41 100644
--- a/services/ui/public/cpp/window_tree_client.cc
+++ b/services/ui/public/cpp/window_tree_client.cc
@@ -1316,22 +1316,14 @@ void WindowTreeClient::WmSetBounds(uint32_t change_id,
Id window_id,
const gfx::Rect& transit_bounds) {
Window* window = GetWindowByServerId(window_id);
- bool result = false;
if (window) {
DCHECK(window_manager_delegate_);
gfx::Rect transit_bounds_in_dip = gfx::ConvertRectToDIP(
ScaleFactorForDisplay(window->display_id()), transit_bounds);
- gfx::Rect bounds = transit_bounds_in_dip;
- result = window_manager_delegate_->OnWmSetBounds(window, &bounds);
- if (result) {
- // If the resulting bounds differ return false. Returning false ensures
- // the client applies the bounds we set below.
- result = bounds == transit_bounds_in_dip;
- window->SetBounds(bounds);
- }
+ window->SetBounds(transit_bounds_in_dip);
mfomitchev 2016/12/06 20:55:20 Don't we still need to call window_manager_delega
thanhph 2016/12/06 21:41:04 The window bound is already set here (window->SetB
mfomitchev 2016/12/06 21:57:11 window_manager_delegate_ (which is ash::mus::Windo
thanhph 2016/12/07 20:48:12 Done, thanks! I added this back in the new cl.
}
if (window_manager_internal_client_)
- window_manager_internal_client_->WmResponse(change_id, result);
+ window_manager_internal_client_->WmResponse(change_id, false);
Fady Samuel 2016/12/06 20:50:07 I'm confused about this? Shouldn't the second argu
mfomitchev 2016/12/06 20:57:44 I think false is right here - we want the client t
thanhph 2016/12/06 21:41:04 Thanks for the reference Mikhail. Let me know if y
}
void WindowTreeClient::WmSetProperty(

Powered by Google App Engine
This is Rietveld 408576698