Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: ui/aura/mus/window_tree_client.cc

Issue 2548513002: Update bool WindowManager::OnWmSetBounds() to match with its desirable behavior. (Closed)
Patch Set: change bool to void. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/aura/mus/window_tree_client.cc
diff --git a/ui/aura/mus/window_tree_client.cc b/ui/aura/mus/window_tree_client.cc
index 9dfb2bb38bc873add46b9cf6463304f2edebc316..f52f42711d20db377eb9e4120c087b8e9534a9ee 100644
--- a/ui/aura/mus/window_tree_client.cc
+++ b/ui/aura/mus/window_tree_client.cc
@@ -1312,14 +1312,11 @@ void WindowTreeClient::WmSetBounds(uint32_t change_id,
DCHECK(window_manager_delegate_);
gfx::Rect bounds = transit_bounds;
// TODO: this needs to trigger scheduling a bounds change on |window|.
- result =
- window_manager_delegate_->OnWmSetBounds(window->GetWindow(), &bounds);
- if (result) {
- // If the resulting bounds differ return false. Returning false ensures
- // the client applies the bounds we set below.
- result = bounds == transit_bounds;
- window->SetBoundsFromServer(bounds);
- }
+ window_manager_delegate_->OnWmSetBounds(window->GetWindow(), &bounds);
+ // If the resulting bounds differ return false. Returning false ensures
+ // the client applies the bounds we set below.
+ window->SetBoundsFromServer(bounds);
+ result = true;
}
if (window_manager_internal_client_)
window_manager_internal_client_->WmResponse(change_id, result);

Powered by Google App Engine
This is Rietveld 408576698