Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: services/ui/public/cpp/tests/window_server_test_base.cc

Issue 2548513002: Update bool WindowManager::OnWmSetBounds() to match with its desirable behavior. (Closed)
Patch Set: change bool to void. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/public/cpp/tests/window_server_test_base.cc
diff --git a/services/ui/public/cpp/tests/window_server_test_base.cc b/services/ui/public/cpp/tests/window_server_test_base.cc
index 55f5e9d2120664a68185aa25187b56ed101d2bfa..e126bcc5664a3482953dfeabc3aefc2a7b03cd6f 100644
--- a/services/ui/public/cpp/tests/window_server_test_base.cc
+++ b/services/ui/public/cpp/tests/window_server_test_base.cc
@@ -118,11 +118,7 @@ void WindowServerTestBase::SetWindowManagerClient(WindowManagerClient* client) {
window_manager_client_ = client;
}
-bool WindowServerTestBase::OnWmSetBounds(Window* window, gfx::Rect* bounds) {
- return window_manager_delegate_
- ? window_manager_delegate_->OnWmSetBounds(window, bounds)
- : true;
-}
+void WindowServerTestBase::OnWmSetBounds(Window* window, gfx::Rect* bounds) {}
Fady Samuel 2016/12/02 23:18:25 This is changing behavior.
thanhph 2016/12/05 17:54:00 Acknowledged.
bool WindowServerTestBase::OnWmSetProperty(
Window* window,

Powered by Google App Engine
This is Rietveld 408576698