Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: ash/mus/window_manager.cc

Issue 2548513002: Update bool WindowManager::OnWmSetBounds() to match with its desirable behavior. (Closed)
Patch Set: change bool to void. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/mus/window_manager.cc
diff --git a/ash/mus/window_manager.cc b/ash/mus/window_manager.cc
index 21d30e96d708e1a837a5d4a4e57bdfec422a4a1b..e89392c9c0cdac102f36a13abde73b65790b624d 100644
--- a/ash/mus/window_manager.cc
+++ b/ash/mus/window_manager.cc
@@ -304,12 +304,10 @@ void WindowManager::SetWindowManagerClient(ui::WindowManagerClient* client) {
window_manager_client_ = client;
}
-bool WindowManager::OnWmSetBounds(ui::Window* window, gfx::Rect* bounds) {
+void WindowManager::OnWmSetBounds(ui::Window* window, gfx::Rect* bounds) {
// TODO(sky): this indirectly sets bounds, which is against what
// OnWmSetBounds() recommends doing. Remove that restriction, or fix this.
WmWindowMus::Get(window)->SetBounds(*bounds);
- *bounds = window->bounds();
- return true;
}
bool WindowManager::OnWmSetProperty(

Powered by Google App Engine
This is Rietveld 408576698