Update bool WindowManager::OnWmSetBounds() to match with its desirable behavior.

services/ui/public/cpp/window_tree_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/ui/public/cpp/window_tree_client.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <utility>
@@ skipping 1298 matching lines @@
 
 void WindowTreeClient::WmDisplayModified(const display::Display& display) {
   DCHECK(window_manager_delegate_);
   window_manager_delegate_->OnWmDisplayModified(display);
 }
 
 void WindowTreeClient::WmSetBounds(uint32_t change_id,
                                        Id window_id,
                                        const gfx::Rect& transit_bounds) {
   Window* window = GetWindowByServerId(window_id);
-  bool result = false;
   if (window) {
     DCHECK(window_manager_delegate_);
     gfx::Rect transit_bounds_in_dip = gfx::ConvertRectToDIP(
         ScaleFactorForDisplay(window->display_id()), transit_bounds);
-    gfx::Rect bounds = transit_bounds_in_dip;
-    result = window_manager_delegate_->OnWmSetBounds(window, &bounds);
-    if (result) {
-      // If the resulting bounds differ return false. Returning false ensures
-      // the client applies the bounds we set below.
-      result = bounds == transit_bounds_in_dip;
-      window->SetBounds(bounds);
-    }
+    window_manager_delegate_->OnWmSetBounds(window, transit_bounds_in_dip);
+    window->SetBounds(transit_bounds_in_dip);

[mfomitchev, 2016/12/07 20:59:46]

This is wrong - we are overwriting the bounds set by WM. I think this should be
removed.

[thanhph, 2016/12/08 00:20:29]

Done.

   }
+
+  // Returning false ensures the client applies the bounds we set below.

[mfomitchev, 2016/12/07 20:59:46]

We are not setting any bounds below :)
We are setting bounds in the delegate.

[thanhph, 2016/12/08 00:20:29]

Done, I removed the comment.

   if (window_manager_internal_client_)
-    window_manager_internal_client_->WmResponse(change_id, result);
+    window_manager_internal_client_->WmResponse(change_id, false);
 }
 
 void WindowTreeClient::WmSetProperty(
     uint32_t change_id,
     Id window_id,
     const std::string& name,
     const base::Optional<std::vector<uint8_t>>& transit_data) {
   Window* window = GetWindowByServerId(window_id);
   bool result = false;
   if (window) {
@@ skipping 132 matching lines @@
     // TODO(riajiang): Figure out if |offset| needs to be converted.
     // (http://crbugs.com/646932)
     window_manager_internal_client_->SetUnderlaySurfaceOffsetAndExtendedHitArea(
         server_id(window), offset.x(), offset.y(),
         gfx::ConvertInsetsToDIP(ScaleFactorForDisplay(window->display_id()),
                                 hit_area));
   }
 }
 
 }  // namespace ui