Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2548493002: [iOS] Upstream scalable resources. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), oshima+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream scalable resources. BUG=None Committed: https://crrev.com/16b321efe70027fc0b2f7e3fe812a20e5162a293 Cr-Commit-Position: refs/heads/master@{#435607}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
A ios/chrome/app/theme/default_100_percent/checkmark.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/error.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/infobar_restore_session.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/omnibox/append_highlighted_ios.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/omnibox/append_incognito_highlighted_ios.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/omnibox/append_incognito_ios.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/omnibox/append_ios.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/omnibox/omnibox_clear.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/omnibox/omnibox_clear_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/omnibox/omnibox_incognito_clear.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/omnibox/omnibox_incognito_clear_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/omnibox/pageinfo_bad.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/omnibox/pageinfo_good.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/omnibox/pageinfo_info.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/omnibox/physical_web_ios.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/checkmark.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/error.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/infobar_restore_session.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/omnibox/append_highlighted_ios.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/omnibox/append_incognito_highlighted_ios.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/omnibox/append_incognito_ios.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/omnibox/append_ios.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/omnibox/omnibox_clear.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/omnibox/omnibox_clear_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/omnibox/omnibox_incognito_clear.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/omnibox/omnibox_incognito_clear_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/omnibox/pageinfo_bad.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/omnibox/pageinfo_good.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/omnibox/pageinfo_info.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/omnibox/physical_web_ios.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/infobar_restore_session.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/omnibox/append_highlighted_ios.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/omnibox/append_incognito_highlighted_ios.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/omnibox/append_incognito_ios.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/omnibox/append_ios.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/omnibox/omnibox_clear.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/omnibox/omnibox_clear_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/omnibox/omnibox_incognito_clear.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/omnibox/omnibox_incognito_clear_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/omnibox/pageinfo_bad.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/omnibox/pageinfo_good.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/omnibox/pageinfo_info.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/omnibox/physical_web_ios.png View Binary file 0 comments Download
M ios/chrome/app/theme/ios_theme_resources.grd View 2 chunks +19 lines, -3 lines 2 comments Download

Messages

Total messages: 12 (7 generated)
sdefresne
Please take a look and send to CQ if LGTY. https://codereview.chromium.org/2548493002/diff/1/ios/chrome/app/theme/ios_theme_resources.grd File ios/chrome/app/theme/ios_theme_resources.grd (left): https://codereview.chromium.org/2548493002/diff/1/ios/chrome/app/theme/ios_theme_resources.grd#oldcode46 ...
4 years ago (2016-12-01 14:29:53 UTC) #4
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-01 14:49:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548493002/1
4 years ago (2016-12-01 14:49:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 15:04:36 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-01 15:08:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16b321efe70027fc0b2f7e3fe812a20e5162a293
Cr-Commit-Position: refs/heads/master@{#435607}

Powered by Google App Engine
This is Rietveld 408576698