Issue 2548483002: [scheduler] Account for disabling throttling in TaskQueueThrottler::IsThrottled

Issue 2548483002: [scheduler] Account for disabling throttling in TaskQueueThrottler::IsThrottled (Closed)

Created:
4 years ago by altimin

Modified:
4 years ago

Reviewers:
Sami

CC:
chromium-reviews, alex clarke (OOO till 29th)

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

[scheduler] Account for disabling throttling in TaskQueueThrottler::IsThrottled TaskQueueThrottler::IsThrottled didn't respect global on/off throttling switch. This led to TaskQueueThrottler::TimeBudgetPool::EnableThrottling permanently disabling some queues. R=skyostil@chromium.org CC=alexclarke@chromium.org BUG=639852 Review-Url: https://codereview.chromium.org/2523673003 Cr-Commit-Position: refs/heads/master@{#434195} (cherry picked from commit 8991961c94284b66c45ef222bdd3f787327a3c81) Committed: https://chromium.googlesource.com/chromium/src/+/a7cff62eea021dba8b9b2949d58a3b477dd8eda4

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -18 lines)			Patch
M	third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc	View	10 chunks	+17 lines, -16 lines	0 comments	Download
M	third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc	View	1 chunk	+60 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

altimin

4 years ago (2016-12-01 14:15:34 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a7cff62eea021dba8b9b2949d58a3b477dd8eda4.