DescriptionRevert of Display content_shell error messages. (patchset #2 id:20001 of https://codereview.chromium.org/2525033003/ )
Reason for revert:
Suspected of causing crashes in win_chromium_rel_ng runs.
e.g. https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/342943/steps/webkit_tests%20%28with%20patch%29/logs/stdio
10:05:33.718 4648 [1202/100532.865:FATAL:sandbox_win.cc(789)] Check failed: base::FilePath(logging::GetLogFileFullPath()).IsAbsolute().
10:05:33.718 4648 Backtrace:
10:05:33.718 4648 base::debug::StackTrace::StackTrace [0x01DB6877+23]
10:05:33.718 4648 logging::LogMessage::~LogMessage [0x01D64C61+49]
10:05:33.718 4648 content::StartSandboxedProcess [0x01012CE2+1101]
10:05:33.718 4648 content::ChildProcessLauncher::Launch [0x01A3BB32+983]
10:05:33.718 4648 Invoke< ?? :: ?? :: ?? ::Callback<void ,base::$00$00,enum content::BrowserThread::ID const &,int const &,ID::SandboxedProcessLauncherDelegate * const &,mojo::edk::ScopedPlatformHandle,base::CommandLine * const &> const &> [0x01A3B0CC+41]
10:05:33.718 4648 ??$RunImpl@ABQ6AXABV?$Callback@$$A6AX$$TVProcess@base@@H@Z$00$00@base@@W4ID@BrowserThread@content@@HPAVSandboxedProcessLauncherDelegate@5@VScopedPlatformHandle@edk@mojo@@PAVCommandLine@2@@ZABV?$tuple@V?$Callback@$$A6AX$$TVProcess@base@@H@Z$00$00@base@@W4I [0x01A3B190+53]
10:05:33.718 4648 base::internal::Invoker<base::internal::BindState<void ,ZV12::nternal,ZV12::CommandLine *>,void __cdecl(void)>::Run [0x01A3BED8+22]
10:05:33.718 4648 base::debug::TaskAnnotator::RunTask [0x01DE32FE+286]
10:05:33.718 4648 base::MessageLoop::RunTask [0x01DA54EC+1228]
10:05:33.718 4648 base::MessageLoop::DoWork [0x01DA4493+611]
10:05:33.718 4648 base::MessagePumpDefault::Run [0x01DE518B+219]
10:05:33.718 4648 base::MessageLoop::RunHandler [0x01DA5011+305]
10:05:33.718 4648 base::RunLoop::Run [0x01DB66AA+122]
10:05:33.718 4648 base::Thread::Run [0x01DA1B6D+173]
10:05:33.718 4648 content::BrowserThreadImpl::ProcessLauncherThreadRun [0x01A1F71C+30]
10:05:33.718 4648 content::BrowserThreadImpl::Run [0x01A1F860+222]
10:05:33.718 4648 base::Thread::ThreadMain [0x01DA266E+622]
10:05:33.719 4648 base::PlatformThread::Sleep [0x01D66982+290]
10:05:33.719 4648 BaseThreadInitThunk [0x7538338A+18]
10:05:33.719 4648 RtlInitializeExceptionChain [0x77359A02+99]
10:05:33.719 4648 RtlInitializeExceptionChain [0x773599D5+54]
Original issue's description:
> Display content_shell error messages.
>
> When run with --run-layout-tests, this change switches content_shell
> logging back to stderr, instead of logging to content_shell.log.
> The layout tests can then capture and display any messages.
>
> BUG=668196
>
> Committed: https://crrev.com/ca8dc086777939dbf144e40feddd6e5d4957b32b
> Cr-Commit-Position: refs/heads/master@{#435954}
TBR=dpranke@chromium.org,peter@chromium.org,jack@nottheoilrig.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668196
Committed: https://crrev.com/d1c680884cf397a504043c63f7ccb906823857d1
Cr-Commit-Position: refs/heads/master@{#435985}
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|