FIELDSET element: |elements| IDL attribute should return an HTMLCollection, not HTMLFormControlsCol…

third_party/WebKit/Source/core/html/HTMLCollection.cpp

Index: third_party/WebKit/Source/core/html/HTMLCollection.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLCollection.cpp b/third_party/WebKit/Source/core/html/HTMLCollection.cpp
index fcb65c161fdc31e2ee0b67db23f8bd2d8614ef51..5f5670a063cb7193fbff3ea4b088c8a572a12891 100644
--- a/third_party/WebKit/Source/core/html/HTMLCollection.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLCollection.cpp
@@ -30,6 +30,7 @@
 #include "core/html/DocumentNameCollection.h"
 #include "core/html/HTMLDataListOptionsCollection.h"
 #include "core/html/HTMLElement.h"
+#include "core/html/HTMLFormControlElement.h"
 #include "core/html/HTMLObjectElement.h"
 #include "core/html/HTMLOptionElement.h"
 #include "core/html/HTMLOptionsCollection.h"
@@ -78,7 +79,8 @@ static bool shouldTypeOnlyIncludeDirectChildren(CollectionType type) {
   return false;
 }
 
-static NodeListRootType rootTypeFromCollectionType(CollectionType type) {
+static NodeListRootType rootTypeFromCollectionType(const ContainerNode& owner,
+                                                   CollectionType type) {
   switch (type) {
     case DocImages:
     case DocApplets:
@@ -90,7 +92,6 @@ static NodeListRootType rootTypeFromCollectionType(CollectionType type) {
     case DocAll:
     case WindowNamedItems:
     case DocumentNamedItems:
-    case FormControls:
       return NodeListRootType::TreeScope;
     case ClassCollectionType:
     case TagCollectionType:
@@ -105,6 +106,11 @@ static NodeListRootType rootTypeFromCollectionType(CollectionType type) {
     case DataListOptions:
     case MapAreas:
       return NodeListRootType::Node;
+    case FormControls:
+      if (isHTMLFieldSetElement(owner))
+        return NodeListRootType::Node;
+      DCHECK(isHTMLFormElement(owner));
+      return NodeListRootType::TreeScope;
     case NameNodeListType:
     case RadioNodeListType:
     case RadioImgNodeListType:
@@ -164,7 +170,7 @@ HTMLCollection::HTMLCollection(ContainerNode& ownerNode,
                                CollectionType type,
                                ItemAfterOverrideType itemAfterOverrideType)
     : LiveNodeListBase(ownerNode,
-                       rootTypeFromCollectionType(type),
+                       rootTypeFromCollectionType(ownerNode, type),
                        invalidationTypeExcludingIdAndNameAttributes(type),
                        type),
       m_overridesItemAfter(itemAfterOverrideType == OverridesItemAfter),
@@ -233,12 +239,16 @@ static inline bool isMatchingHTMLElement(const HTMLCollection& htmlCollection,
              element.fastHasAttribute(hrefAttr);
     case DocAnchors:
       return element.hasTagName(aTag) && element.fastHasAttribute(nameAttr);
+

[kochi, 2016/12/02 09:15:19]

nit: no empty lines on L242 & L246?  (following the convention in this block)

[tkent, 2016/12/02 13:09:23]

Done.

+    case FormControls:
+      DCHECK(isHTMLFieldSetElement(htmlCollection.ownerNode()));
+      return isHTMLObjectElement(element) || isHTMLFormControlElement(element);
+
     case ClassCollectionType:
     case TagCollectionType:
     case HTMLTagCollectionType:
     case DocAll:
     case NodeChildren:
-    case FormControls:
     case TableRows:
     case WindowNamedItems:
     case NameNodeListType: