Add perspective support to SkMatrix44 initializers.

include/utils/SkMatrix44.h

Index: include/utils/SkMatrix44.h
diff --git a/include/utils/SkMatrix44.h b/include/utils/SkMatrix44.h
index 9d9b6e01029e5b7887d8aa2059e2b79430a234ef..0a65d81e60618e6fae849735fd52b9014400700e 100644
--- a/include/utils/SkMatrix44.h
+++ b/include/utils/SkMatrix44.h
@@ -137,6 +137,14 @@ public:
         return !(other == *this);
     }
 
+    /* When converting from SkMatrix44 to SkMatrix, the third row and
+     * column is dropped.  When converting from SkMatrix to SkMatrix44
+     * the third row and column remain as identity:
+     * [ a b c ]      [ a b 0 c ]
+     * [ d e f ]  ->  [ d e 0 f ]
+     * [ g h i ]      [ 0 0 1 0 ]
+     *                [ g h 0 i ]
+     */
     SkMatrix44(const SkMatrix&);
     SkMatrix44& operator=(const SkMatrix& src);
     operator SkMatrix() const;
@@ -253,6 +261,8 @@ public:
     void setRowMajor(const SkMScalar data[]) { this->setRowMajord(data); }
 #endif
 
+    /* This sets the top-left of the matrix, i.e. the translation and
+     * perspective components remain untouched. */

[reed1, 2013/10/03 09:00:40]

the i.e. section is incorrect: set3x3 sets *all* elements of the matrix: the
top-left corner is set by the params, but translate and perspective elements are
set to 0 (with [3][3] set to 1).

This is consistent with skia's general matrix naming convention. all of its
set... methods always overwrite the entire matrix, as opposed to its various
concat/preconcat/postconcat methods, which may ignore some fields, or
read-modify others.

[aelias_OOO_until_Jul13, 2013/10/03 19:05:36]

Right, fixed the comment.

     void set3x3(SkMScalar m00, SkMScalar m01, SkMScalar m02,
                 SkMScalar m10, SkMScalar m11, SkMScalar m12,
                 SkMScalar m20, SkMScalar m21, SkMScalar m22);