Don't commit prefs::kStabilitySessionEndCompleted change immediately on chromeos

chrome/browser/browser_process_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_process_impl.h"
 
 #include <algorithm>
 #include <map>
 #include <vector>
 
@@ skipping 344 matching lines @@
 
 void BrowserProcessImpl::EndSession() {
   // Mark all the profiles as clean.
   ProfileManager* pm = profile_manager();
   std::vector<Profile*> profiles(pm->GetLoadedProfiles());
   for (size_t i = 0; i < profiles.size(); ++i)
     profiles[i]->SetExitType(Profile::EXIT_SESSION_ENDED);
 
   // Tell the metrics service it was cleanly shutdown.
   MetricsService* metrics = g_browser_process->metrics_service();
-  if (metrics && local_state()) {
+  // MetricsService::RecordStartOfSessionEnd writes to prefs immediately.

[jar (doing other things), 2013/10/02 01:18:31]

Can you point to where this happens?  I don't see it.

If it is true, then the comment should be between lines 366 and 367, and hence
inside curlies.

+  if (metrics && local_state())
     metrics->RecordStartOfSessionEnd();
 
-    // MetricsService lazily writes to prefs, force it to write now.
-    local_state()->CommitPendingWrite();
-  }
-
   // http://crbug.com/125207
   base::ThreadRestrictions::ScopedAllowWait allow_wait;
 
   // We must write that the profile and metrics service shutdown cleanly,
   // otherwise on startup we'll think we crashed. So we block until done and
   // then proceed with normal shutdown.
 #if defined(USE_X11)
   //  Can't run a local loop on linux. Instead create a waitable event.
   scoped_ptr<base::WaitableEvent> done_writing(
       new base::WaitableEvent(false, false));
@@ skipping 674 matching lines @@
 }
 
 void BrowserProcessImpl::OnAutoupdateTimer() {
   if (CanAutorestartForUpdate()) {
     DLOG(WARNING) << "Detected update.  Restarting browser.";
     RestartBackgroundInstance();
   }
 }
 
 #endif  // (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS)