Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 2548393002: PushMessaging.UnregistrationReason UMA should count GCM Store resets (Closed)

Created:
4 years ago by johnme
Modified:
4 years ago
CC:
chromium-reviews, Peter Beverloo, johnme+watch_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, harkness+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PushMessaging.UnregistrationReason UMA should count GCM Store resets BUG=671203 Committed: https://crrev.com/749c7daaa5a048b51d96b8bd2b4277ea3a54c252 Cr-Commit-Position: refs/heads/master@{#437005}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/push_messaging/push_messaging_service_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/push_messaging_status.h View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
johnme
4 years ago (2016-12-05 15:47:51 UTC) #4
harkness
lgtm
4 years ago (2016-12-06 13:01:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548393002/1
4 years ago (2016-12-06 15:24:39 UTC) #9
johnme
piman: Please approve content/public/ asvitkine: Please approve histograms Thanks!
4 years ago (2016-12-06 15:28:21 UTC) #12
Alexei Svitkine (slow)
lgtm
4 years ago (2016-12-06 15:37:31 UTC) #13
piman
lgtm
4 years ago (2016-12-06 21:16:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548393002/1
4 years ago (2016-12-07 16:02:24 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 18:08:03 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-07 18:11:53 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/749c7daaa5a048b51d96b8bd2b4277ea3a54c252
Cr-Commit-Position: refs/heads/master@{#437005}

Powered by Google App Engine
This is Rietveld 408576698