Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2548383002: Remove two NOTIMPLEMENTED() added in CL 2544103002 to reduce console spam (Closed)

Created:
4 years ago by Alex Z.
Modified:
4 years ago
Reviewers:
msw, sadrul, Fady Samuel
CC:
chromium-reviews, rjkroege, kylechar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove two NOTIMPLEMENTED() added in CL 2544103002 to reduce console spam BUG=659601 TBR=msw@chromium.org, sadrul@chromium.org Committed: https://crrev.com/105c120724c4d7d0e8c89dfcefb20e847f2a2c4c Cr-Commit-Position: refs/heads/master@{#436322}

Patch Set 1 #

Patch Set 2 : Removed NOTIMPLEMENTED() in aura::WindowCompositorFrameSink::WillDrawSurface() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M services/ui/public/cpp/window_compositor_frame_sink.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/frame_generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/mus/window_compositor_frame_sink.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
Alex Z.
Please review my changes.
4 years ago (2016-12-05 15:30:24 UTC) #2
Fady Samuel
What about the aura version?
4 years ago (2016-12-05 15:39:05 UTC) #5
Fady Samuel
What about the aura version?
4 years ago (2016-12-05 15:39:05 UTC) #6
Fady Samuel
https://cs.chromium.org/chromium/src/ui/aura/mus/window_compositor_frame_sink.cc?sq=package:chromium&l=116
4 years ago (2016-12-05 15:39:30 UTC) #7
Alex Z.
On 2016/12/05 15:39:05, Fady Samuel wrote: > What about the aura version? Oops missed that ...
4 years ago (2016-12-05 15:44:51 UTC) #8
Alex Z.
sadrul@chromium.org: Please review changes in ui/aura/mus/window_compositor_frame_sink.cc
4 years ago (2016-12-05 15:45:42 UTC) #10
Fady Samuel
lgtm. Feel free to TBR folks on this.
4 years ago (2016-12-05 15:47:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548383002/20001
4 years ago (2016-12-05 15:56:55 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 16:46:29 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/105c120724c4d7d0e8c89dfcefb20e847f2a2c4c Cr-Commit-Position: refs/heads/master@{#436322}
4 years ago (2016-12-05 16:48:37 UTC) #19
msw
lgtm; as an aside, the TODOs would be better with bug citations.
4 years ago (2016-12-05 18:33:33 UTC) #20
sadrul
4 years ago (2016-12-07 16:15:45 UTC) #21
Message was sent while issue was closed.
On 2016/12/05 18:33:33, msw wrote:
> lgtm; as an aside, the TODOs would be better with bug citations.

The other option is to set NOTIMPLEMENTED_POLICY on the target (e.g.
https://cs.chromium.org/chromium/src/ash/mus/BUILD.gn?q=NOTIMPLEMENTED_POLICY...)

Powered by Google App Engine
This is Rietveld 408576698