Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: components/omnibox/browser/omnibox_field_trial.h

Issue 2548363010: Omnibox - Refactor |relevance_buckets| to Remove Memory Leak on Exit (Closed)
Patch Set: 0.8 -> 0.8f Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/omnibox/browser/omnibox_field_trial.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/browser/omnibox_field_trial.h
diff --git a/components/omnibox/browser/omnibox_field_trial.h b/components/omnibox/browser/omnibox_field_trial.h
index c4c6afe7d1a2e68a7720a87ff9c0894b9d979ab5..ff72ad1f9c2f1ce814d91b5494b37ae2da713bcb 100644
--- a/components/omnibox/browser/omnibox_field_trial.h
+++ b/components/omnibox/browser/omnibox_field_trial.h
@@ -270,22 +270,15 @@ class OmniboxFieldTrial {
// For HQP scoring related experiments to control the topicality and scoring
// ranges of relevancy scores.
- // Returns true if HQP experimental scoring is enabled. Returns false if
- // |kHQPExperimentalScoringEnabledParam| is not specified in the field trial.
- static bool HQPExperimentalScoringEnabled();
-
- // Returns the scoring buckets for HQP experiments. Returns empty string
- // in case |kHQPExperimentalScoringBucketsParam| or
- // |kHQPExperimentalScoringEnabledParam| is not specified in the
- // field trial. Scoring buckets are stored in string form giving mapping from
- // (topicality_score, frequency_score) to final relevance score.
- // Please see GetRelevancyScore() under
- // chrome/browser/history::ScoredHistoryMatch for details.
+ // Returns the scoring buckets for HQP experiments. Returns an empty string
+ // if scoring buckets are not specified in the field trial. Scoring buckets
+ // are stored in string form giving mapping from (topicality_score,
+ // frequency_score) to final relevance score. Please see GetRelevancyScore()
+ // under chrome/browser/history::ScoredHistoryMatch for details.
static std::string HQPExperimentalScoringBuckets();
- // Returns the topicality threshold for HQP experiments. Returns -1 if
- // |kHQPExperimentalScoringTopicalityThresholdParam| or
- // |kHQPExperimentalScoringEnabledParam| is not specified in the field trial.
+ // Returns the topicality threshold for HQP experiments. Returns a default
+ // value of 0.8 if no threshold is specified in the field trial.
static float HQPExperimentalTopicalityThreshold();
// ---------------------------------------------------------
@@ -411,7 +404,6 @@ class OmniboxFieldTrial {
static const char kHUPNewScoringVisitedCountUseDecayFactorParam[];
// Parameter names used by the HQP experimental scoring experiments.
- static const char kHQPExperimentalScoringEnabledParam[];
static const char kHQPExperimentalScoringBucketsParam[];
static const char kHQPExperimentalScoringTopicalityThresholdParam[];
« no previous file with comments | « no previous file | components/omnibox/browser/omnibox_field_trial.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698