Omnibox - Refactor |relevance_buckets| to Remove Memory Leak on Exit

components/omnibox/browser/omnibox_field_trial.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_
 #define COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 252 matching lines @@
 
   // Returns how the search provider should poll Suggest. Currently, we support
   // measuring polling delay from the last keystroke or last suggest request.
   static void GetSuggestPollingStrategy(bool* from_last_keystroke,
                                         int* polling_delay_ms);
 
   // ---------------------------------------------------------
   // For HQP scoring related experiments to control the topicality and scoring
   // ranges of relevancy scores.
 
-  // Returns true if HQP experimental scoring is enabled. Returns false if
-  // |kHQPExperimentalScoringEnabledParam| is not specified in the field trial.
-  static bool HQPExperimentalScoringEnabled();
-
-  // Returns the scoring buckets for HQP experiments. Returns empty string
-  // in case |kHQPExperimentalScoringBucketsParam| or
-  // |kHQPExperimentalScoringEnabledParam| is not specified in the
+  // Returns the scoring buckets for HQP experiments. Returns an empty string
+  // in case |kHQPExperimentalScoringBucketsParam| is not specified in the
   // field trial. Scoring buckets are stored in string form giving mapping from
   // (topicality_score, frequency_score) to final relevance score.
   // Please see GetRelevancyScore() under
   // chrome/browser/history::ScoredHistoryMatch for details.
   static std::string HQPExperimentalScoringBuckets();
 
-  // Returns the topicality threshold for HQP experiments. Returns -1 if
-  // |kHQPExperimentalScoringTopicalityThresholdParam| or
-  // |kHQPExperimentalScoringEnabledParam| is not specified in the field trial.
+  // Returns the topicality threshold for HQP experiments. Returns 0.8 if

[Peter Kasting, 2016/12/10 02:31:15]

Nit: I dunno if it would be clearer to say "returns a default value of 0.8
if..."?

[Mark P, 2016/12/11 04:57:22]

I agree.  Made two changes: added the mention of "default" and removed the
reference to the parameter name.  None of the other trials here mention the
parameter name.

+  // |kHQPExperimentalScoringTopicalityThresholdParam| is not specified in the
+  // field trial.
   static float HQPExperimentalTopicalityThreshold();
 
   // ---------------------------------------------------------
   // For the HQPFixFrequencyScoring experiment that's part of the
   // bundled omnibox field trial.
 
   // Returns true if HQP should apply the bug fix to discount the visits to
   // pages visited less than ten times.
   static bool HQPFixFewVisitsBug();
 
@@ skipping 105 matching lines @@
   static const char kHUPNewScoringTypedCountRelevanceCapParam[];
   static const char kHUPNewScoringTypedCountHalfLifeTimeParam[];
   static const char kHUPNewScoringTypedCountScoreBucketsParam[];
   static const char kHUPNewScoringTypedCountUseDecayFactorParam[];
   static const char kHUPNewScoringVisitedCountRelevanceCapParam[];
   static const char kHUPNewScoringVisitedCountHalfLifeTimeParam[];
   static const char kHUPNewScoringVisitedCountScoreBucketsParam[];
   static const char kHUPNewScoringVisitedCountUseDecayFactorParam[];
 
   // Parameter names used by the HQP experimental scoring experiments.
-  static const char kHQPExperimentalScoringEnabledParam[];
   static const char kHQPExperimentalScoringBucketsParam[];
   static const char kHQPExperimentalScoringTopicalityThresholdParam[];
 
   // The amount of time to wait before sending a new suggest request after the
   // previous one unless overridden by a field trial parameter.
   // Non-const because some unittests modify this value.
   static int kDefaultMinimumTimeBetweenSuggestQueriesMs;
 
  private:
   friend class OmniboxFieldTrialTest;
@@ skipping 14 matching lines @@
   // prioritize different wildcard contexts, see the implementation.  How to
   // interpret the value is left to the caller; this is rule-dependent.
   static std::string GetValueForRuleInContext(
       const std::string& rule,
       metrics::OmniboxEventProto::PageClassification page_classification);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial);
 };
 
 #endif  // COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_