Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 2548363004: Disallow dropping or pasting files to a volume with unrecognized partition. (Closed)

Created:
4 years ago by yamaguchi
Modified:
4 years ago
Reviewers:
fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow dropping or pasting files to a volume with unrecognized partition. BUG=631957 TEST=manual test as noted in the bug CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/40415e909045db52fddee4c425f82a556aaa3317 Cr-Commit-Position: refs/heads/master@{#436560}

Patch Set 1 #

Patch Set 2 : refer the right field name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_transfer_controller.js View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
yamaguchi
ptal
4 years ago (2016-12-06 08:07:53 UTC) #5
fukino
lgtm
4 years ago (2016-12-06 09:40:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548363004/20001
4 years ago (2016-12-06 10:19:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548363004/20001
4 years ago (2016-12-06 10:19:59 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 10:24:29 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-06 10:26:36 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/40415e909045db52fddee4c425f82a556aaa3317
Cr-Commit-Position: refs/heads/master@{#436560}

Powered by Google App Engine
This is Rietveld 408576698