Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2548363003: Require someone working on PlzNavigate to approve changes to the test filters. (Closed)

Created:
4 years ago by jam
Modified:
4 years ago
Reviewers:
nasko, scottmg
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Require someone working on PlzNavigate to approve changes to the test filters. Since PlzNavigate is close to launching, we want to ensure that someone from the team approves any new additions to the test filters for browser_tests & content_browsertests, which are almost empty now. BUG=368813 Committed: https://crrev.com/d8a6bf34335f3bebf7beac12493d10ee5e4fa7d3 Cr-Commit-Position: refs/heads/master@{#436398}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M testing/buildbot/filters/OWNERS View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
jam
4 years ago (2016-12-05 18:13:04 UTC) #2
scottmg
lgtm
4 years ago (2016-12-05 18:17:49 UTC) #6
nasko
LGTM with a suggestion. https://codereview.chromium.org/2548363003/diff/1/testing/buildbot/filters/OWNERS File testing/buildbot/filters/OWNERS (right): https://codereview.chromium.org/2548363003/diff/1/testing/buildbot/filters/OWNERS#newcode10 testing/buildbot/filters/OWNERS:10: per-file browser-side-navigation*=yzshen@chromium.org I'd suggest adding ...
4 years ago (2016-12-05 18:18:28 UTC) #7
jam
https://codereview.chromium.org/2548363003/diff/1/testing/buildbot/filters/OWNERS File testing/buildbot/filters/OWNERS (right): https://codereview.chromium.org/2548363003/diff/1/testing/buildbot/filters/OWNERS#newcode10 testing/buildbot/filters/OWNERS:10: per-file browser-side-navigation*=yzshen@chromium.org On 2016/12/05 18:18:28, nasko wrote: > I'd ...
4 years ago (2016-12-05 19:28:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548363003/20001
4 years ago (2016-12-05 19:28:14 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 20:53:07 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-05 20:55:13 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d8a6bf34335f3bebf7beac12493d10ee5e4fa7d3
Cr-Commit-Position: refs/heads/master@{#436398}

Powered by Google App Engine
This is Rietveld 408576698