Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2548353004: Include BT addresses in Intents from Physical Web (Closed)

Created:
4 years ago by cco3
Modified:
4 years ago
Reviewers:
nyquist, mattreynolds
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include BT addresses in Intents from Physical Web This change uses BluetoothDevice.EXTRA_DEVICE to include the bluetooth address of a Physical Web device in the intent sent to the browser. This may be used by the browser to enable more seamless connections to BT devices. BUG=671400 Committed: https://crrev.com/071c8d5f611a0e60c3521feecbdf868a2361fdd4 Cr-Commit-Position: refs/heads/master@{#437300}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java View 3 chunks +24 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java View 4 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
cco3
4 years ago (2016-12-06 00:59:20 UTC) #2
mattreynolds
lgtm
4 years ago (2016-12-06 02:01:37 UTC) #3
cco3
4 years ago (2016-12-06 18:33:47 UTC) #5
nyquist
lgtm
4 years ago (2016-12-07 00:57:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548353004/1
4 years ago (2016-12-07 01:42:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/80808)
4 years ago (2016-12-07 02:09:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548353004/20001
4 years ago (2016-12-08 18:15:27 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 19:06:11 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-08 19:11:07 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/071c8d5f611a0e60c3521feecbdf868a2361fdd4
Cr-Commit-Position: refs/heads/master@{#437300}

Powered by Google App Engine
This is Rietveld 408576698