Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: components/ntp_snippets/remote/ntp_snippets_fetcher.h

Issue 2548343002: NTPSnippets: Set MaxRetriesOn5xx only for interactive requests. (Closed)
Patch Set: Ability of FetcherFactory to warn about multiple |Create| calls. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/ntp_snippets_fetcher.h
diff --git a/components/ntp_snippets/remote/ntp_snippets_fetcher.h b/components/ntp_snippets/remote/ntp_snippets_fetcher.h
index 62437c99096287262a34c2022b1411af6ca86f7f..7427485918e3759920e1094caf798b83b7d4de44 100644
--- a/components/ntp_snippets/remote/ntp_snippets_fetcher.h
+++ b/components/ntp_snippets/remote/ntp_snippets_fetcher.h
@@ -223,6 +223,10 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
const scoped_refptr<net::URLRequestContextGetter>& context_getter);
RequestBuilder& SetUserClassifier(const UserClassifier& user_classifier);
+ // These preview methods allow to inspect the Request without exposing it
+ // publicly.
+ // TODO(fhorschig): Remove these when moving the RequestBuilder to
+ // snippets::internal and trigger the request to intercept the request.
std::string PreviewRequestBodyForTesting() { return BuildBody(); }
std::string PreviewRequestHeadersForTesting() { return BuildHeaders(); }
RequestBuilder& SetUserClassForTesting(const std::string& user_class) {

Powered by Google App Engine
This is Rietveld 408576698