Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 254833003: Sync VTTCue.align/vertical with spec (Closed)

Created:
6 years, 8 months ago by philipj_slow
Modified:
6 years, 7 months ago
CC:
blink-reviews, nessy, arv+blink, gasubic, fs, eric.carlson_apple.com, watchdog-blink-watchlist_google.com, dglazkov+blink, adamk+blink_chromium.org, Inactive, vcarbune.chromium, ojan
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : compile? #

Patch Set 3 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -44 lines) Patch
M LayoutTests/media/track/opera/interfaces/VTTCue/align.html View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/media/track/opera/interfaces/VTTCue/vertical.html View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/media/track/track-cue-mutable.html View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/media/track/track-cue-mutable-expected.txt View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/media/track/vtt-cue-exceptions.html View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/media/track/vtt-cue-exceptions-expected.txt View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.cpp View 1 2 4 chunks +4 lines, -16 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.idl View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
philipj_slow
6 years, 7 months ago (2014-04-27 19:59:03 UTC) #1
fs
LGTM
6 years, 7 months ago (2014-04-28 08:40:53 UTC) #2
philipj_slow
Jochen, can you review the IDL change?
6 years, 7 months ago (2014-04-28 08:45:24 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-04-28 09:20:26 UTC) #4
philipj_slow
Aaron, do you want to take a look as well?
6 years, 7 months ago (2014-04-28 21:11:01 UTC) #5
acolwell GONE FROM CHROMIUM
lgtm
6 years, 7 months ago (2014-04-28 22:16:01 UTC) #6
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 7 months ago (2014-04-29 07:32:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/254833003/40001
6 years, 7 months ago (2014-04-29 07:33:09 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 07:34:16 UTC) #9
Message was sent while issue was closed.
Change committed as 172854

Powered by Google App Engine
This is Rietveld 408576698