[wasm] Implement location from stack trace for asm.js frames

[wasm] Implement location from stack trace for asm.js frames

This avoids the crash which ClusterFuzz found, but still does not
report the same position as without validate.asm.
For calls like "foo()|0", we report the position of the call instead of
the position of the "|" if ToNumber throws an error.

After this CL, the correctness-fuzzer for validate-asm will probably
find mismatches there.

R=titzer@chromium.org
BUG=chromium:670808
Committed: https://crrev.com/6a8dccb19731fe78ce0d576876677734a7c0ae5e
Cr-Commit-Position: refs/heads/master@{#41500}

[Clemens Hammacher, 2016-12-05 11:40:43]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 11:40:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 12:06:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 12:06:44]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-12-05 12:14:36]

lgtm

https://codereview.chromium.org/2548323002/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/2548323002/diff/1/src/isolate.cc#newcode1536
src/isolate.cc:1536: bool
Isolate::ComputeLocationFromStackTrace(MessageLocation* target,
Can you add a comment explaining what this does (basically the in-person
discussion we just had)?

[Clemens Hammacher, 2016-12-05 12:27:29]

https://codereview.chromium.org/2548323002/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/2548323002/diff/1/src/isolate.cc#newcode1536
src/isolate.cc:1536: bool
Isolate::ComputeLocationFromStackTrace(MessageLocation* target,
On 2016/12/05 at 12:14:36, titzer wrote:
> Can you add a comment explaining what this does (basically the in-person
discussion we just had)?

isolate.h provides this documentation:
// Attempts to compute the current source location, storing the
// result in the target out parameter.

Isn't that enough?
The location is currently needed for generating a message object for the
uncaught exception, this message object is then delivered to the embedder by
MessageHandler::ReportMessage.
Should I add this to the comment?

[titzer, 2016-12-05 12:34:09]

On 2016/12/05 12:27:29, Clemens Hammacher wrote:
> https://codereview.chromium.org/2548323002/diff/1/src/isolate.cc
> File src/isolate.cc (right):
> 
> https://codereview.chromium.org/2548323002/diff/1/src/isolate.cc#newcode1536
> src/isolate.cc:1536: bool
> Isolate::ComputeLocationFromStackTrace(MessageLocation* target,
> On 2016/12/05 at 12:14:36, titzer wrote:
> > Can you add a comment explaining what this does (basically the in-person
> discussion we just had)?
> 
> isolate.h provides this documentation:
> // Attempts to compute the current source location, storing the
> // result in the target out parameter.
> 
> Isn't that enough?
> The location is currently needed for generating a message object for the
> uncaught exception, this message object is then delivered to the embedder by
> MessageHandler::ReportMessage.
> Should I add this to the comment?

Yeah, something to that effect would be good.

[Clemens Hammacher, 2016-12-05 18:46:28]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-12-05 18:46:28]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2548323002/#ps20001
(title: "Add comment")

[commit-bot: I haz the power, 2016-12-05 18:46:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 19:29:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480963588463000,
"parent_rev": "53c0b95a79c244694dbf8b17a01c4793110f7101", "commit_rev":
"95307eb555907962768e7adc49ce47b8927fa970"}

[commit-bot: I haz the power, 2016-12-05 19:29:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-05 19:30:26]

Description was changed from

==========
[wasm] Implement location from stack trace for asm.js frames

This avoids the crash which ClusterFuzz found, but still does not
report the same position as without validate.asm.
For calls like "foo()|0", we report the position of the call instead of
the position of the "|" if ToNumber throws an error.

After this CL, the correctness-fuzzer for validate-asm will probably
find mismatches there.

R=titzer@chromium.org
BUG=chromium:670808
==========

to

==========
[wasm] Implement location from stack trace for asm.js frames

This avoids the crash which ClusterFuzz found, but still does not
report the same position as without validate.asm.
For calls like "foo()|0", we report the position of the call instead of
the position of the "|" if ToNumber throws an error.

After this CL, the correctness-fuzzer for validate-asm will probably
find mismatches there.

R=titzer@chromium.org
BUG=chromium:670808

Committed: https://crrev.com/6a8dccb19731fe78ce0d576876677734a7c0ae5e
Cr-Commit-Position: refs/heads/master@{#41500}
==========

[commit-bot: I haz the power, 2016-12-05 19:30:27]

Patchset 2 (id:??) landed as
https://crrev.com/6a8dccb19731fe78ce0d576876677734a7c0ae5e
Cr-Commit-Position: refs/heads/master@{#41500}