Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 2548313003: Revert of [ObjC ARC] Converts ios/public/consumer/base:base to ARC.Automatically generated ARCMigrat (Closed)

Created:
4 years ago by lpromero
Modified:
4 years ago
Reviewers:
stkhapugin, sdefresne
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ObjC ARC] Converts ios/public/consumer/base:base to ARC.Automatically generated ARCMigrate commi… (patchset #2 id:20001 of https://codereview.chromium.org/2533453002/ ) Reason for revert: The .cc is nowhere to be found. Original issue's description: > [ObjC ARC] Converts ios/public/consumer/base:base to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Committed: https://crrev.com/6d6dd774e50cf758953a2606dc5904cddde5c799 > Cr-Commit-Position: refs/heads/master@{#436281} TBR=sdefresne@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624363 Committed: https://crrev.com/fc4ae6b485f2561dfa08cee89d6ed62bdacea0e0 Cr-Commit-Position: refs/heads/master@{#436310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
A ios/consumer/base/debugger.mm View 1 chunk +14 lines, -0 lines 0 comments Download
M ios/public/consumer/base/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
lpromero
Created Revert of [ObjC ARC] Converts ios/public/consumer/base:base to ARC.Automatically generated ARCMigrate commi…
4 years ago (2016-12-05 16:21:26 UTC) #2
sdefresne
4 years ago (2016-12-05 17:11:06 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698