Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2548253005: FindInPage: fix wrong match ordinal after javascript update. (Closed)

Created:
4 years ago by kotenkov
Modified:
4 years ago
Reviewers:
tkent, dvadym
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FindInPage: fix wrong match ordinal after javascript update. BUG=672003 TEST=ParameterizedWebFrameTest.FindInPageJavaScriptUpdatesDOMProperOrdinal Committed: https://crrev.com/e9eaa9c7c71d2006397954a8b731b631db8576cf Cr-Commit-Position: refs/heads/master@{#437498}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -1 line) Patch
M third_party/WebKit/Source/web/TextFinder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +82 lines, -0 lines 1 comment Download

Messages

Total messages: 16 (10 generated)
kotenkov
Please see the bug for the description of the problem.
4 years ago (2016-12-07 11:14:49 UTC) #5
kotenkov
https://codereview.chromium.org/2548253005/diff/1/third_party/WebKit/Source/web/tests/WebFrameTest.cpp File third_party/WebKit/Source/web/tests/WebFrameTest.cpp (right): https://codereview.chromium.org/2548253005/diff/1/third_party/WebKit/Source/web/tests/WebFrameTest.cpp#newcode5007 third_party/WebKit/Source/web/tests/WebFrameTest.cpp:5007: struct FakeTimerSetter { There are a couple of places ...
4 years ago (2016-12-07 11:22:34 UTC) #6
tkent
lgtm
4 years ago (2016-12-08 01:53:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548253005/1
4 years ago (2016-12-09 07:36:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 08:51:08 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-09 08:52:56 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9eaa9c7c71d2006397954a8b731b631db8576cf
Cr-Commit-Position: refs/heads/master@{#437498}

Powered by Google App Engine
This is Rietveld 408576698